Changeset 94066 in webkit

Timestamp:

Aug 30, 2011, 3:54:47 AM (15 years ago)

Author:

yurys@chromium.org

Message:

2011-08-30 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update window.onerror tests after r94061 to match new semantics
of window.onerror return value.

• fast/workers/resources/shared-worker-script-error.js:
• http/tests/security/cross-origin-script-window-onerror-redirected.html:
• http/tests/security/cross-origin-script-window-onerror.html:
• userscripts/window-onerror-for-isolated-world-1.html:
• userscripts/window-onerror-for-isolated-world-2.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/workers/resources/shared-worker-script-error.js (modified) (1 diff)
• http/tests/security/cross-origin-script-window-onerror-redirected.html (modified) (1 diff)
• http/tests/security/cross-origin-script-window-onerror.html (modified) (1 diff)
• userscripts/window-onerror-for-isolated-world-1.html (modified) (2 diffs)
• userscripts/window-onerror-for-isolated-world-2.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-08-30  Yury Semikhatsky  <yurys@chromium.org>
+
+        Unreviewed. Update window.onerror tests after r94061 to match new semantics
+        of window.onerror return value.
+
+        * fast/workers/resources/shared-worker-script-error.js:
+        * http/tests/security/cross-origin-script-window-onerror-redirected.html:
+        * http/tests/security/cross-origin-script-window-onerror.html:
+        * userscripts/window-onerror-for-isolated-world-1.html:
+        * userscripts/window-onerror-for-isolated-world-2.html:
+
 2011-08-30  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/LayoutTests/fast/workers/resources/shared-worker-script-error.js

@@ -14 +14 @@
         onerror = function(message, url, lineno) {
             port.postMessage("SUCCESS: error handled via onerror: " + message);
-            return false;
+            return true;
         };
         generateError();  // Undefined function call

trunk/LayoutTests/http/tests/security/cross-origin-script-window-onerror-redirected.html

@@ -15 +15 @@
   if (window.layoutTestController)
     layoutTestController.notifyDone();
-  return false;
+  return true;
 }
 </script>

trunk/LayoutTests/http/tests/security/cross-origin-script-window-onerror.html

@@ -17 +17 @@
   if (window.layoutTestController)
     layoutTestController.notifyDone();
-  return false;
+  return true;
 }
 </script>

trunk/LayoutTests/userscripts/window-onerror-for-isolated-world-1.html

@@ -32 +32 @@
 {
     log("Main world window.onerror: " + msg + " at " + lastUrlComponent(url) + ":" + line);
-    return false;
+    return true;
 }
 
@@ -39 +39 @@
     var url = lastUrlComponent(e.filename);
     log("Main world error event listener: " + e.message + " at " + url + ":" + e.lineno);
+    e.preventDefault();
 }, false);
 

trunk/LayoutTests/userscripts/window-onerror-for-isolated-world-2.html

@@ -45 +45 @@
     window.onerror = function(msg, url, line) {
         log(isolatedWorld + " window.onerror: " + msg + " at " + lastUrlComponent(url) + ":" + line, "*");
-        return false;
+        return true;
     }