⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 94080 in webkit


Ignore:
Timestamp:
Aug 30, 2011, 9:10:11 AM (15 years ago)
Author:
commit-queue@webkit.org
Message:

The unused ScrollView* argument can and should be removed from
scrollRectIntoView.
​https://bugs.webkit.org/show_bug.cgi?id=67117

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-08-30
Reviewed by Darin Adler.

Source/WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::scrollRectIntoView):

  • page/Chrome.cpp:

(WebCore::Chrome::scrollRectIntoView):

  • page/ChromeClient.h:

(WebCore::ChromeClient::scrollRectIntoView):

Source/WebKit/chromium:

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::scrollRectIntoView):

  • src/WebPopupMenuImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.h:

(WebCore::ChromeClientEfl::scrollRectIntoView):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::scrollRectIntoView):

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::scrollRectIntoView):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::scrollRectIntoView):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::scrollRectIntoView):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::scrollRectIntoView):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::scrollRectIntoView):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scrollRectIntoView):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
Location:
trunk/Source
Files:
27 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r94079 r94080  
     12011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        The unused ScrollView* argument can and should be removed from
     4        scrollRectIntoView.
     5        https://bugs.webkit.org/show_bug.cgi?id=67117
     6
     7        Reviewed by Darin Adler.
     8
     9        * loader/EmptyClients.h:
     10        (WebCore::EmptyChromeClient::scrollRectIntoView):
     11        * page/Chrome.cpp:
     12        (WebCore::Chrome::scrollRectIntoView):
     13        * page/ChromeClient.h:
     14        (WebCore::ChromeClient::scrollRectIntoView):
     15
    1162011-08-30  Ben Wells  <benwells@chromium.org>
    217

  • trunk/Source/WebCore/loader/EmptyClients.h

    r93303 r94080  
    215215    virtual void setCursorHiddenUntilMouseMoves(bool) { }
    216216
    217     virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const {}
     217    virtual void scrollRectIntoView(const IntRect&) const { }
    218218
    219219    virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*) {}

  • trunk/Source/WebCore/page/Chrome.cpp

    r93303 r94080  
    128128void Chrome::scrollRectIntoView(const IntRect& rect) const
    129129{
    130     // FIXME: The unused ScrollView* argument can and should be removed from ChromeClient::scrollRectIntoView.
    131     m_client->scrollRectIntoView(rect, 0);
     130    m_client->scrollRectIntoView(rect);
    132131}
    133132

  • trunk/Source/WebCore/page/ChromeClient.h

    r93303 r94080  
    169169        virtual void contentsSizeChanged(Frame*, const IntSize&) const = 0;
    170170        virtual void layoutUpdated(Frame*) const { }
    171         virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const = 0; // Currently only Mac has a non empty implementation.
     171        virtual void scrollRectIntoView(const IntRect&) { }; // Currently only Mac has a non empty implementation.
    172172       
    173173        virtual bool shouldMissingPluginMessageBeButton() const { return false; }

  • trunk/Source/WebKit/chromium/ChangeLog

    r94004 r94080  
     12011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        The unused ScrollView* argument can and should be removed from
     4        scrollRectIntoView.
     5        https://bugs.webkit.org/show_bug.cgi?id=67117
     6
     7        Reviewed by Darin Adler.
     8
     9        * src/WebPopupMenuImpl.cpp:
     10        (WebKit::WebPopupMenuImpl::scrollRectIntoView):
     11        * src/WebPopupMenuImpl.h:
     12
    1132011-08-29  Greg Billock  <gbillock@google.com>
    214

  • trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp

    r93009 r94080  
    398398}
    399399
    400 void WebPopupMenuImpl::scrollRectIntoView(const IntRect&, const ScrollView*) const
     400void WebPopupMenuImpl::scrollRectIntoView(const IntRect&) const
    401401{
    402402    // Nothing to be done here since we do not have the concept of a container

  • trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h

    r92699 r94080  
    129129    virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&) const;
    130130    virtual PlatformPageClient platformPageClient() const { return 0; }
    131     virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const;
     131    virtual void scrollRectIntoView(const WebCore::IntRect&) const;
    132132    virtual void scrollbarsModeDidChange() const;
    133133    virtual void setCursor(const WebCore::Cursor&);

  • trunk/Source/WebKit/efl/ChangeLog

    r94063 r94080  
     12011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        The unused ScrollView* argument can and should be removed from
     4        scrollRectIntoView.
     5        https://bugs.webkit.org/show_bug.cgi?id=67117
     6
     7        Reviewed by Darin Adler.
     8
     9        * WebCoreSupport/ChromeClientEfl.h:
     10        (WebCore::ChromeClientEfl::scrollRectIntoView):
     11
    1122011-08-30  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
    213

  • trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h

    r93303 r94080  
    148148    virtual void setCursorHiddenUntilMouseMoves(bool);
    149149
    150     virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const { }
     150    virtual void scrollRectIntoView(const IntRect&) const { }
    151151
    152152    virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*);

  • trunk/Source/WebKit/gtk/ChangeLog

    r93867 r94080  
     12011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        The unused ScrollView* argument can and should be removed from
     4        scrollRectIntoView.
     5        https://bugs.webkit.org/show_bug.cgi?id=67117
     6
     7        Reviewed by Darin Adler.
     8
     9        * WebCoreSupport/ChromeClientGtk.h:
     10        (WebKit::ChromeClient::scrollRectIntoView):
     11
    1122011-08-26  Gustavo Noronha Silva  <gns@gnome.org>
    213

  • trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h

    r93303 r94080  
    134134        virtual void setCursorHiddenUntilMouseMoves(bool);
    135135
    136         virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const {}
     136        virtual void scrollRectIntoView(const WebCore::IntRect&) const { }
    137137        virtual void requestGeolocationPermissionForFrame(WebCore::Frame*, WebCore::Geolocation*);
    138138        virtual void cancelGeolocationPermissionRequestForFrame(WebCore::Frame*, WebCore::Geolocation*);

  • trunk/Source/WebKit/haiku/ChangeLog

    r93303 r94080  
     12011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        The unused ScrollView* argument can and should be removed from
     4        scrollRectIntoView.
     5        https://bugs.webkit.org/show_bug.cgi?id=67117
     6
     7        Reviewed by Darin Adler.
     8
     9        * WebCoreSupport/ChromeClientHaiku.cpp:
     10        (WebCore::ChromeClientHaiku::scrollRectIntoView):
     11
    1122011-08-17  Adam Roben  <aroben@apple.com>
    213

  • trunk/Source/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp

    r93303 r94080  
    302302}
    303303
    304 void ChromeClientHaiku::scrollRectIntoView(const IntRect&, const ScrollView*) const
     304void ChromeClientHaiku::scrollRectIntoView(const IntRect&) const
    305305{
    306306    notImplemented();

  • trunk/Source/WebKit/mac/ChangeLog

    r94007 r94080  
     12011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        The unused ScrollView* argument can and should be removed from
     4        scrollRectIntoView.
     5        https://bugs.webkit.org/show_bug.cgi?id=67117
     6
     7        Reviewed by Darin Adler.
     8
     9        * WebCoreSupport/WebChromeClient.h:
     10        * WebCoreSupport/WebChromeClient.mm:
     11        (WebChromeClient::scrollRectIntoView):
     12
    1132011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
    214

  • trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h

    r93980 r94080  
    9898    virtual PlatformPageClient platformPageClient() const;
    9999    virtual void contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const;
    100     virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const;
     100    virtual void scrollRectIntoView(const WebCore::IntRect&) const;
    101101   
    102102    virtual void setStatusbarText(const WTF::String&);

  • trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm

    r93980 r94080  
    609609}
    610610
    611 void WebChromeClient::scrollRectIntoView(const IntRect& r, const ScrollView*) const
     611void WebChromeClient::scrollRectIntoView(const IntRect& r) const
    612612{
    613613    // FIXME: This scrolling behavior should be under the control of the embedding client,

  • trunk/Source/WebKit/qt/ChangeLog

    r93787 r94080  
     12011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        The unused ScrollView* argument can and should be removed from
     4        scrollRectIntoView.
     5        https://bugs.webkit.org/show_bug.cgi?id=67117
     6
     7        Reviewed by Darin Adler.
     8
     9        * WebCoreSupport/ChromeClientQt.h:
     10        (WebCore::ChromeClientQt::scrollRectIntoView):
     11
    1122011-08-25  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
    213

  • trunk/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h

    r93303 r94080  
    181181    virtual void setCursorHiddenUntilMouseMoves(bool) { }
    182182
    183     virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const { }
     183    virtual void scrollRectIntoView(const IntRect&) const { }
    184184
    185185    virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*) { }

  • trunk/Source/WebKit/win/ChangeLog

    r94049 r94080  
     12011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        The unused ScrollView* argument can and should be removed from
     4        scrollRectIntoView.
     5        https://bugs.webkit.org/show_bug.cgi?id=67117
     6
     7        Reviewed by Darin Adler.
     8
     9        * WebCoreSupport/WebChromeClient.h:
     10        (WebChromeClient::scrollRectIntoView):
     11
    1122011-08-29  Ryosuke Niwa  <rniwa@webkit.org>
    213

  • trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h

    r93303 r94080  
    154154#endif
    155155
    156     virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const {}
     156    virtual void scrollRectIntoView(const WebCore::IntRect&) const { }
    157157
    158158    // FIXME: Remove once all ports are using client-based geolocation. https://bugs.webkit.org/show_bug.cgi?id=40373

  • trunk/Source/WebKit/wince/ChangeLog

    r93303 r94080  
     12011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        The unused ScrollView* argument can and should be removed from
     4        scrollRectIntoView.
     5        https://bugs.webkit.org/show_bug.cgi?id=67117
     6
     7        Reviewed by Darin Adler.
     8
     9        * WebCoreSupport/ChromeClientWinCE.h:
     10
    1112011-08-17  Adam Roben  <aroben@apple.com>
    212

  • trunk/Source/WebKit/wince/WebCoreSupport/ChromeClientWinCE.h

    r93303 r94080  
    102102    virtual PlatformPageClient platformPageClient() const;
    103103    virtual void contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const;
    104     virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const; // Currently only Mac has a non empty implementation.
     104    virtual void scrollRectIntoView(const WebCore::IntRect&) const; // Currently only Mac has a non empty implementation.
    105105    virtual void scrollbarsModeDidChange() const;
    106106    virtual void setCursor(const WebCore::Cursor&);

  • trunk/Source/WebKit/wx/ChangeLog

    r93303 r94080  
     12011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        The unused ScrollView* argument can and should be removed from
     4        scrollRectIntoView.
     5        https://bugs.webkit.org/show_bug.cgi?id=67117
     6
     7        Reviewed by Darin Adler.
     8
     9        * WebKitSupport/ChromeClientWx.h:
     10        (WebCore::ChromeClientWx::scrollRectIntoView):
     11
    1122011-08-17  Adam Roben  <aroben@apple.com>
    213

  • trunk/Source/WebKit/wx/WebKitSupport/ChromeClientWx.h

    r93303 r94080  
    142142    virtual void setCursorHiddenUntilMouseMoves(bool) { }
    143143
    144     virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const {}
     144    virtual void scrollRectIntoView(const IntRect&) const { }
    145145
    146146    virtual void requestGeolocationPermissionForFrame(Frame*, Geolocation*);

  • trunk/Source/WebKit2/ChangeLog

    r94051 r94080  
     12011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        The unused ScrollView* argument can and should be removed from
     4        scrollRectIntoView.
     5        https://bugs.webkit.org/show_bug.cgi?id=67117
     6
     7        Reviewed by Darin Adler.
     8
     9        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
     10        (WebKit::WebChromeClient::scrollRectIntoView):
     11        * WebProcess/WebCoreSupport/WebChromeClient.h:
     12
    1132011-08-29  Ryosuke Niwa  <rniwa@webkit.org>
    214

  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp

    r93981 r94080  
    464464}
    465465
    466 void WebChromeClient::scrollRectIntoView(const IntRect&, const ScrollView*) const
     466void WebChromeClient::scrollRectIntoView(const IntRect&) const
    467467{
    468468    notImplemented();

  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h

    r93980 r94080  
    120120    virtual PlatformPageClient platformPageClient() const;
    121121    virtual void contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const;
    122     virtual void scrollRectIntoView(const WebCore::IntRect&, const WebCore::ScrollView*) const; // Currently only Mac has a non empty implementation.
     122    virtual void scrollRectIntoView(const WebCore::IntRect&) const; // Currently only Mac has a non empty implementation.
    123123    // End methods used by HostWindow.
    124124
Note: See TracChangeset for help on using the changeset viewer.