Changeset 94082 in webkit

Timestamp:

Aug 30, 2011, 9:35:32 AM (15 years ago)

Author:

tony@chromium.org

Message:

Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
​https://bugs.webkit.org/show_bug.cgi?id=67168

Reviewed by Adam Barth.

webcore_bindings_sources generates various files (e.g., CSSPropertyNames,
DerivedSources, HTMLNames, etc). webcore_bindings depends on webcore_bindings_sources
and compiles these files. Previously, the other webcore libs (webcore_svg,
webcore_html, webcore_remaining, etc) depended on webcore_bindings. This changes the
dependency on webocre_bindings_sources so the build can parallelize the compile of
webcore_bindings and the other webcore_* libs.

No new tests, just changing the build dependencies. Manually copy over the
include dirs that we used to get from webcore_bindings' direct_dependent_settings.

• WebCore.gyp/WebCore.gyp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gyp/WebCore.gyp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-30  Tony Chang  <tony@chromium.org>
+
+        Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
+        https://bugs.webkit.org/show_bug.cgi?id=67168
+
+        Reviewed by Adam Barth.
+
+        webcore_bindings_sources generates various files (e.g., CSSPropertyNames,
+        DerivedSources, HTMLNames, etc).  webcore_bindings depends on webcore_bindings_sources
+        and compiles these files.  Previously, the other webcore libs (webcore_svg,
+        webcore_html, webcore_remaining, etc) depended on webcore_bindings.  This changes the
+        dependency on webocre_bindings_sources so the build can parallelize the compile of
+        webcore_bindings and the other webcore_* libs.
+
+        No new tests, just changing the build dependencies.  Manually copy over the
+        include dirs that we used to get from webcore_bindings' direct_dependent_settings.
+
+        * WebCore.gyp/WebCore.gyp:
+
 2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
 

trunk/Source/WebCore/WebCore.gyp/WebCore.gyp

@@ -1046 +1046 @@
       'type': 'none',
       'dependencies': [
-        'webcore_bindings',
+        'webcore_bindings_sources',
         '../../ThirdParty/glu/glu.gyp:libtess',
         '../../JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp:yarr',
@@ -1064 +1064 @@
       ],
       'export_dependent_settings': [
-        'webcore_bindings',
         '../../JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp:yarr',
         '../../JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp:wtf',
@@ -1092 +1091 @@
           '<(chromium_src_dir)/gpu',
           '<(chromium_src_dir)/third_party/angle/include/GLSLANG',
+          '<(SHARED_INTERMEDIATE_DIR)/webkit',
+          '<(SHARED_INTERMEDIATE_DIR)/webkit/bindings',
         ],
         'mac_framework_dirs': [