Changeset 94787 in webkit


Ignore:
Timestamp:
Sep 8, 2011 1:19:34 PM (13 years ago)
Author:
eric.carlson@apple.com
Message:

HTMLMediaElement is missing initialTime attribute
​https://bugs.webkit.org/show_bug.cgi?id=67791

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-initialTime.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::initialTime):

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::initialTime):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::initialTime):

LayoutTests:

  • media/media-initialTime-expected.txt: Added.
  • media/media-initialTime.html: Added.
Location:
trunk
Files:
2 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r94785 r94787  
     12011-09-08  Eric Carlson  <eric.carlson@apple.com>
     2
     3        HTMLMediaElement is missing initialTime attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=67791
     5
     6        Reviewed by Darin Adler.
     7
     8        * media/media-initialTime-expected.txt: Added.
     9        * media/media-initialTime.html: Added.
     10
    1112011-09-03  Robert Hogan  <robert@webkit.org>
    212

  • trunk/Source/WebCore/ChangeLog

    r94785 r94787  
     12011-09-08  Eric Carlson  <eric.carlson@apple.com>
     2
     3        HTMLMediaElement is missing initialTime attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=67791
     5
     6        Reviewed by Darin Adler.
     7
     8        Test: media/media-initialTime.html
     9
     10        * html/HTMLMediaElement.cpp:
     11        (WebCore::HTMLMediaElement::initialTime):
     12        * html/HTMLMediaElement.h:
     13        * html/HTMLMediaElement.idl:
     14        * platform/graphics/MediaPlayer.cpp:
     15        (WebCore::MediaPlayer::initialTime):
     16        * platform/graphics/MediaPlayer.h:
     17        * platform/graphics/MediaPlayerPrivate.h:
     18        (WebCore::MediaPlayerPrivateInterface::initialTime):
     19
    1202011-09-03  Robert Hogan  <robert@webkit.org>
    221

  • trunk/Source/WebCore/html/HTMLMediaElement.cpp

    r94608 r94787  
    14731473}
    14741474
     1475double HTMLMediaElement::initialTime() const
     1476{
     1477    if (!m_player)
     1478        return 0;
     1479    return m_player->initialTime();
     1480}
     1481
    14751482float HTMLMediaElement::duration() const
    14761483{

  • trunk/Source/WebCore/html/HTMLMediaElement.h

    r94406 r94787  
    112112    float currentTime() const;
    113113    void setCurrentTime(float, ExceptionCode&);
     114    double initialTime() const;
    114115    float startTime() const;
    115116    float duration() const;

  • trunk/Source/WebCore/html/HTMLMediaElement.idl

    r94590 r94787  
    6161    attribute float currentTime
    6262        setter raises (DOMException);
     63    readonly attribute double initialTime;
    6364    readonly attribute float startTime;
    6465    readonly attribute float duration;

  • trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp

    r94121 r94787  
    460460}
    461461
     462double MediaPlayer::initialTime() const
     463{
     464    return m_private->initialTime();
     465}
     466
    462467float MediaPlayer::currentTime() const
    463468{

  • trunk/Source/WebCore/platform/graphics/MediaPlayer.h

    r94121 r94787  
    235235    float startTime() const;
    236236
     237    double initialTime() const;
     238
    237239    float rate() const;
    238240    void setRate(float);

  • trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h

    r94121 r94787  
    7272
    7373    virtual float startTime() const { return 0; }
     74
     75    virtual double initialTime() const { return 0; }
    7476
    7577    virtual void setRate(float) = 0;
Note: See TracChangeset for help on using the changeset viewer.