Changeset 95053 in webkit

Timestamp:

Sep 13, 2011, 3:41:36 PM (15 years ago)

Author:

Beth Dakin

Message:

Adding a comment I forgot to add before.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::imageSizeForError):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderImage.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-13  Beth Dakin  <bdakin@apple.com>
+
+        Adding a comment I forgot to add before.
+
+        * rendering/RenderImage.cpp:
+        (WebCore::RenderImage::imageSizeForError):
+
 2011-09-13  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/rendering/RenderImage.cpp

@@ -89 +89 @@
         float deviceScaleFactor = Page::deviceScaleFactor(frame());
         imageSize = newImage->brokenImage(deviceScaleFactor)->size();
-        if (deviceScaleFactor >= 2)
-            imageSize.scale(0.5f);        
+        if (deviceScaleFactor >= 2) {
+            // It is important to scale by 0.5 instead of the deviceScaleFactor because the
+            // high resolution broken image artwork is actually a 2x image. We should 
+            // consider adding functionality to Image to ask about the image's resolution,
+            // and then we could scale by 1 / resolution. This is a solution that would
+            // scale better since this hardcoded number will have to change if we ever get
+            // artwork at other, higher resolutions. 
+            imageSize.scale(0.5f);
+        }
     } else
         imageSize = newImage->image()->size();