Changeset 95356 in webkit

Timestamp:

Sep 16, 2011 7:42:16 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Depend on harfbuzz for OS=Android as well
​https://bugs.webkit.org/show_bug.cgi?id=68239

Like GTK, Android depends on harfbuzz as well, so reflect that in
the project file. Furthermore, fix a compile error in PopupListBox.cpp
by explicitly including ctype.h, as isspace otherwise won't be declared.

Patch by Peter Beverloo <​peter@chromium.org> on 2011-09-16
Reviewed by Steve Block.

• WebCore.gyp/WebCore.gyp:
• platform/chromium/PopupListBox.cpp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gyp/WebCore.gyp (modified) (1 diff)
• platform/chromium/PopupListBox.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-16  Peter Beverloo  <peter@chromium.org>
+
+        Depend on harfbuzz for OS=Android as well
+        https://bugs.webkit.org/show_bug.cgi?id=68239
+
+        Like GTK, Android depends on harfbuzz as well, so reflect that in
+        the project file. Furthermore, fix a compile error in PopupListBox.cpp
+        by explicitly including ctype.h, as isspace otherwise won't be declared.
+
+        Reviewed by Steve Block.
+
+        * WebCore.gyp/WebCore.gyp:
+        * platform/chromium/PopupListBox.cpp:
+
 2011-09-16  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/WebCore.gyp/WebCore.gyp

@@ -1377 +1377 @@
             ['include', 'platform/graphics/chromium/SimpleFontDataLinux\\.cpp$'],
           ],
+        }],
+        ['toolkit_uses_gtk==1 or OS=="android"', {
           'dependencies': [
             '<(chromium_src_dir)/third_party/harfbuzz/harfbuzz.gyp:harfbuzz',

trunk/Source/WebCore/platform/chromium/PopupListBox.cpp

@@ -48 +48 @@
 #include "StringTruncator.h"
 #include "TextRun.h"
+#include <ctype.h>
 #include <limits>
 #include <wtf/CurrentTime.h>