Changeset 96937 in webkit

Timestamp:

Oct 7, 2011 7:56:12 AM (13 years ago)

Author:

podivilov@chromium.org

Message:

Unreviewed, rolling out r96892.
​http://trac.webkit.org/changeset/96892
​https://bugs.webkit.org/show_bug.cgi?id=69626

it broke windows canary bots (Requested by podivilov on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-07

• WebCore.gyp/scripts/rule_binding.py:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gyp/scripts/rule_binding.py (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r96892.
+        http://trac.webkit.org/changeset/96892
+        https://bugs.webkit.org/show_bug.cgi?id=69626
+
+        it broke windows canary bots (Requested by podivilov on
+        #webkit).
+
+        * WebCore.gyp/scripts/rule_binding.py:
+
 2011-10-07  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebCore/WebCore.gyp/scripts/rule_binding.py

@@ -50 +50 @@
 import shlex
 import shutil
+import subprocess
 import sys
 
@@ -124 +125 @@
     command.extend(['--outputDir', cppdir, input])
 
-    # Do it.
-    os.execvp('perl', command)
+    # Do it. check_call is new in 2.5, so simulate its behavior with call and
+    # assert.
+    returnCode = subprocess.call(command)
+    assert returnCode == 0
+
+    return returnCode
 
 
 if __name__ == '__main__':
-    main(sys.argv)
+    sys.exit(main(sys.argv))