Changeset 97304 in webkit

Timestamp:

Oct 12, 2011, 2:34:38 PM (15 years ago)

Author:

mitz@apple.com

Message:

Hang beneath PluginProcessProxy::createPropertyListFile() when using a thin build
​https://bugs.webkit.org/show_bug.cgi?id=69960

Reviewed by Adam Roben.

• UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::createPropertyListFile): Check for any non-zero return value
from posix_spawn() rather than for a negative return value. The old, incorrect check, caused
this function to hang in waitpid() after failing to spawn a plug-in process for a 32-bit plug-in
when WebKit2 was built for 64-bit only.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Plugins/mac/PluginProcessProxyMac.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-10-12  Dan Bernstein  <mitz@apple.com>
+
+        Hang beneath PluginProcessProxy::createPropertyListFile() when using a thin build
+        https://bugs.webkit.org/show_bug.cgi?id=69960
+
+        Reviewed by Adam Roben.
+
+        * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
+        (WebKit::PluginProcessProxy::createPropertyListFile): Check for any non-zero return value
+        from posix_spawn() rather than for a negative return value. The old, incorrect check, caused
+        this function to hang in waitpid() after failing to spawn a plug-in process for a 32-bit plug-in
+        when WebKit2 was built for 64-bit only.
+
 2011-10-12  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
 

trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm

@@ -98 +98 @@
     posix_spawnattr_destroy(&attr);
 
-    if (result < 0)
+    if (result)
         return false;
     int status;