Changeset 98392 in webkit

Timestamp:

Oct 25, 2011, 1:59:15 PM (15 years ago)

Author:

commit-queue@webkit.org

Message:

LayerRendererChromium::setVisible called needlessly without a visibility change
​https://bugs.webkit.org/show_bug.cgi?id=70766

Patch by Michal Mocny <​mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

Check that visibility has actually changed before calling LayerRendererChromium::setVisible

• platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):

• platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp (modified) (2 diffs)
• platform/graphics/chromium/cc/CCLayerTreeHostImpl.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-10-25  Michal Mocny  <mmocny@google.com>
+
+        LayerRendererChromium::setVisible called needlessly without a visibility change
+        https://bugs.webkit.org/show_bug.cgi?id=70766
+
+        Reviewed by Kenneth Russell.
+
+        Check that visibility has actually changed before calling LayerRendererChromium::setVisible
+
+        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+        (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
+        (WebCore::CCLayerTreeHostImpl::setVisible):
+        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+
 2011-10-25  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp

@@ -49 +49 @@
     , m_frameNumber(0)
     , m_settings(settings)
+    , m_visible(true)
 {
     ASSERT(CCProxy::isImplThread());
@@ -129 +130 @@
 void CCLayerTreeHostImpl::setVisible(bool visible)
 {
+    if (m_visible == visible)
+        return;
+    m_visible = visible;
+
     if (m_layerRenderer)
         m_layerRenderer->setVisible(visible);

trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h

@@ -110 +110 @@
     CCSettings m_settings;
     IntSize m_viewportSize;
+    bool m_visible;
 };