⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 98687 in webkit


Ignore:
Timestamp:
Oct 27, 2011, 9:55:21 PM (15 years ago)
Author:
abarth@webkit.org
Message:

Dis-integrate run-bindings-tests with webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=71092

Reviewed by Ryosuke Niwa.

These tests aren't really adding any value.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
Location:
trunk/Tools
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r98682 r98687  
     12011-10-27  Adam Barth  <abarth@webkit.org>
     2
     3        Dis-integrate run-bindings-tests with webkitpy
     4        https://bugs.webkit.org/show_bug.cgi?id=71092
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        These tests aren't really adding any value.
     9
     10        * Scripts/webkitpy/common/config/ports.py:
     11        * Scripts/webkitpy/tool/commands/download_unittest.py:
     12        * Scripts/webkitpy/tool/mocktool.py:
     13        * Scripts/webkitpy/tool/steps/runtests.py:
     14        * Scripts/webkitpy/tool/steps/runtests_unittest.py:
     15        * Scripts/webkitpy/tool/steps/steps_unittest.py:
     16
    1172011-10-27  Eric Seidel  <eric@webkit.org>
    218

  • trunk/Tools/Scripts/webkitpy/common/config/ports.py

    r90864 r98687  
    118118
    119119    @classmethod
    120     def run_bindings_tests_command(cls):
    121         return cls.script_shell_command("run-bindings-tests")
    122 
    123     @classmethod
    124120    def layout_tests_results_path(cls):
    125121        return "/tmp/layout-test-results/results.html"

  • trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py

    r97521 r98687  
    9090
    9191    def test_build_and_test(self):
    92         expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\n"
     92        expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\n"
    9393        self.assert_execute_outputs(BuildAndTest(), [], options=self._default_options(), expected_stderr=expected_stderr)
    9494
    … …  
    116116
    117117    def test_land(self):
    118         expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 50000\n"
     118        expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 50000\n"
    119119        mock_tool = MockTool()
    120120        mock_tool.scm().create_patch = Mock(return_value="Patch1\nMockPatch\n")
    … …  
    137137Running Perl unit tests
    138138MOCK run_and_throw_if_fail: ['mock-test-webkitperl'], cwd=/mock-checkout
    139 Running Bindings tests
    140 MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
    141139Running JavaScriptCore tests
    142140MOCK run_and_throw_if_fail: ['mock-run-javacriptcore-tests'], cwd=/mock-checkout
    … …  
    151149
    152150    def test_land_red_builders(self):
    153         expected_stderr = 'Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 50000\n'
     151        expected_stderr = 'Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 50000\n'
    154152        mock_tool = MockTool()
    155153        mock_tool.buildbot.light_tree_on_fire()
    … …  
    177175Running Python unit tests
    178176Running Perl unit tests
    179 Running Bindings tests
    180177Running JavaScriptCore tests
    181178Running run-webkit-tests
    … …  
    194191Running Python unit tests
    195192Running Perl unit tests
    196 Running Bindings tests
    197193Running JavaScriptCore tests
    198194Running run-webkit-tests
    … …  
    204200Running Python unit tests
    205201Running Perl unit tests
    206 Running Bindings tests
    207202Running JavaScriptCore tests
    208203Running run-webkit-tests

  • trunk/Tools/Scripts/webkitpy/tool/mocktool.py

    r97515 r98687  
    785785        return ["mock-build-webkit"]
    786786
    787     def run_bindings_tests_command(self):
    788         return ["mock-run-bindings-tests"]
    789 
    790787    def prepare_changelog_command(self):
    791788        return ['mock-prepare-ChangeLog']

  • trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py

    r91210 r98687  
    5757            self._tool.executive.run_and_throw_if_fail(perl_unittests_command, cwd=self._tool.scm().checkout_root)
    5858
    59         bindings_tests_command = self._tool.port().run_bindings_tests_command()
    60         if bindings_tests_command:
    61             log("Running Bindings tests")
    62             self._tool.executive.run_and_throw_if_fail(bindings_tests_command, cwd=self._tool.scm().checkout_root)
    63 
    6459        javascriptcore_tests_command = self._tool.port().run_javascriptcore_tests_command()
    6560        if javascriptcore_tests_command:

  • trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py

    r89289 r98687  
    3939        tool._port.run_perl_unittests_command = lambda: None
    4040        step = RunTests(tool, MockOptions(test=True, non_interactive=True, quiet=False))
    41         expected_stderr = """Running Bindings tests
    42 Running JavaScriptCore tests
     41        expected_stderr = """Running JavaScriptCore tests
    4342Running run-webkit-tests
    4443"""

  • trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py

    r95543 r98687  
    8080Running Perl unit tests
    8181MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitperl'], cwd=/mock-checkout
    82 Running Bindings tests
    83 MOCK run_and_throw_if_fail: ['Tools/Scripts/run-bindings-tests'], cwd=/mock-checkout
    8482Running JavaScriptCore tests
    8583MOCK run_and_throw_if_fail: ['Tools/Scripts/run-javascriptcore-tests'], cwd=/mock-checkout
Note: See TracChangeset for help on using the changeset viewer.