Changeset 98693 in webkit

Timestamp:

Oct 27, 2011, 10:39:13 PM (15 years ago)

Author:

yutak@chromium.org

Message:

WebSocket: Connecting to localhost:8880 takes one second on Windows
​https://bugs.webkit.org/show_bug.cgi?id=64788

Reviewed by Dirk Pranke.

• Scripts/webkitpy/layout_tests/servers/websocket_server.py:

Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
from timing out on Windows, because this test tries to open a lot of
connections to localhost and each attempt takes one second to fall back from
IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/servers/websocket_server.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-10-27  Yuta Kitamura  <yutak@chromium.org>
+
+        WebSocket: Connecting to localhost:8880 takes one second on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=64788
+
+        Reviewed by Dirk Pranke.
+
+        * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
+        Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
+        IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
+        from timing out on Windows, because this test tries to open a lot of
+        connections to localhost and each attempt takes one second to fall back from
+        IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
+
 2011-10-27  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py

@@ -118 +118 @@
         start_cmd = [
             python_interp, '-u', pywebsocket_script,
-            '--server-host', '127.0.0.1',
+            '--server-host', 'localhost',
             '--port', str(self._port),
             # FIXME: Don't we have a self._port_obj.layout_test_path?