Changeset 98756 in webkit

Timestamp:

Oct 28, 2011, 1:27:44 PM (15 years ago)

Author:

ap@apple.com

Message:

Clean up BuiltInPDFView a little
​https://bugs.webkit.org/show_bug.cgi?id=71133

Reviewed by Daniel Bates.

• WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::createScrollbar):

Removed an incorrect FIXME. Custom scrollbars specified in a document don't apply
to subframes, and thus shouldn't apply to PDFs.

• WebProcess/Plugins/PDF/BuiltInPDFView.h: (WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):

Moved to a correct location. This is not a Plugin method, but a ScrollView one.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Plugins/PDF/BuiltInPDFView.cpp (modified) (1 diff)
• WebProcess/Plugins/PDF/BuiltInPDFView.h (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-10-28  Alexey Proskuryakov  <ap@apple.com>
+
+        Clean up BuiltInPDFView a little
+        https://bugs.webkit.org/show_bug.cgi?id=71133
+
+        Reviewed by Daniel Bates.
+
+        * WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::createScrollbar):
+        Removed an incorrect FIXME. Custom scrollbars specified in a document don't apply
+        to subframes, and thus shouldn't apply to PDFs.
+
+        * WebProcess/Plugins/PDF/BuiltInPDFView.h: (WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):
+        Moved to a correct location. This is not a Plugin method, but a ScrollView one.
+
 2011-10-28  Jochen Eisinger  <jochen@chromium.org>
 

trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp

@@ -162 +162 @@
 PassRefPtr<Scrollbar> BuiltInPDFView::createScrollbar(ScrollbarOrientation orientation)
 {
-    // FIXME: Support custom scrollbar styles.
     RefPtr<Scrollbar> widget = Scrollbar::createNativeScrollbar(this, orientation, RegularScrollbar);
     if (orientation == HorizontalScrollbar)

trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h

@@ -92 +92 @@
     virtual void manualStreamDidFinishLoading();
     virtual void manualStreamDidFail(bool wasCancelled);
-
-    virtual void zoomAnimatorTransformChanged(float, float, float, ZoomAnimationState) { }
-
     virtual bool handleMouseEvent(const WebMouseEvent&);
     virtual bool handleWheelEvent(const WebWheelEvent&);
@@ -141 +138 @@
     virtual bool shouldSuspendScrollAnimations() const { return false; } // If we return true, ScrollAnimatorMac will keep cycling a timer forever, waiting for a good time to animate.
     virtual void scrollbarStyleChanged();
+    virtual void zoomAnimatorTransformChanged(float, float, float, ZoomAnimationState) { }
 
     // FIXME: Implement the other conversion functions; this one is enough to get scrollbar hit testing working.