⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 98789 in webkit


Ignore:
Timestamp:
Oct 28, 2011, 5:51:37 PM (15 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r98776.
​http://trac.webkit.org/changeset/98776
​https://bugs.webkit.org/show_bug.cgi?id=71164

caused lots of test crashes (Requested by smfr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-10-28

Source/WebCore:

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateVisibilityStatus):
(WebCore::RenderLayer::dirtyZOrderLists):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::enableCompositingMode):

LayoutTests:

  • animations/resources/animation-test-helpers.js:

(checkExpectedValue):

  • compositing/visibility/animation-visibility-expected.png: Removed.
  • compositing/visibility/animation-visibility-expected.txt: Removed.
  • compositing/visibility/animation-visibility.html: Removed.
Location:
trunk
Files:
3 deleted
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r98782 r98789  
     12011-10-28  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r98776.
     4        http://trac.webkit.org/changeset/98776
     5        https://bugs.webkit.org/show_bug.cgi?id=71164
     6
     7        caused lots of test crashes (Requested by smfr on #webkit).
     8
     9        * animations/resources/animation-test-helpers.js:
     10        (checkExpectedValue):
     11        * compositing/visibility/animation-visibility-expected.png: Removed.
     12        * compositing/visibility/animation-visibility-expected.txt: Removed.
     13        * compositing/visibility/animation-visibility.html: Removed.
     14
    1152011-10-28 Sadrul Habib Chowdhury  <sadrul@chromium.org>
    216

  • trunk/LayoutTests/animations/resources/animation-test-helpers.js

    r98776 r98789  
    3333
    3434*/
    35 
    36 const doPixelTest = true;
    37 const dontDoPixelTest = false;
    3835
    3936function isCloseEnough(actual, desired, tolerance)
    … …  
    144141        else
    145142            pass = isCloseEnough(computedValue, expectedValue, tolerance);
    146     } else if (property == "visibility") {
    147         var element;
    148         if (iframeId)
    149             element = document.getElementById(iframeId).contentDocument.getElementById(elementId);
    150         else
    151             element = document.getElementById(elementId);
    152 
    153         computedValue = window.getComputedStyle(element).visibility;
    154         if (compareElements) {
    155             computedValue2 = window.getComputedStyle(document.getElementById(elementId2)).visibility;
    156             pass = computedValue == computedValue2;
    157         }
    158         else
    159             pass = computedValue == expectedValue;
    160143    } else {
    161144        var element;

  • trunk/Source/WebCore/ChangeLog

    r98788 r98789  
     12011-10-28  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r98776.
     4        http://trac.webkit.org/changeset/98776
     5        https://bugs.webkit.org/show_bug.cgi?id=71164
     6
     7        caused lots of test crashes (Requested by smfr on #webkit).
     8
     9        * rendering/RenderLayer.cpp:
     10        (WebCore::RenderLayer::updateVisibilityStatus):
     11        (WebCore::RenderLayer::dirtyZOrderLists):
     12        * rendering/RenderLayer.h:
     13        * rendering/RenderLayerCompositor.cpp:
     14        (WebCore::RenderLayerCompositor::enableCompositingMode):
     15
    1162011-10-28  John Sullivan  <sullivan@apple.com>
    217

  • trunk/Source/WebCore/rendering/RenderLayer.cpp

    r98776 r98789  
    618618        m_hasVisibleDescendant = false;
    619619        for (RenderLayer* child = firstChild(); child; child = child->nextSibling()) {
    620             child->updateVisibilityStatus();
     620            child->updateVisibilityStatus();       
    621621            if (child->m_hasVisibleContent || child->m_hasVisibleDescendant) {
    622622                m_hasVisibleDescendant = true;
    … …  
    39713971void RenderLayer::dirtyZOrderLists()
    39723972{
    3973     dirtyZOrderListsInternal();
    3974    
    3975 #if USE(ACCELERATED_COMPOSITING)
    3976     if (!renderer()->documentBeingDestroyed())
    3977         compositor()->setCompositingLayersNeedRebuild();
    3978 #endif
    3979 }
    3980 
    3981 void RenderLayer::dirtyZOrderListsInternal()
    3982 {
    39833973    if (m_posZOrderList)
    39843974        m_posZOrderList->clear();
    … …  
    39863976        m_negZOrderList->clear();
    39873977    m_zOrderListsDirty = true;
    3988 }
    3989 
    3990 void RenderLayer::dirtyZOrderListsIncludingDescendants()
    3991 {
    3992     dirtyZOrderListsInternal();
    3993 
    3994     for (RenderLayer* child = firstChild(); child; child = child->nextSibling())
    3995         child->dirtyZOrderListsIncludingDescendants();
     3978
     3979#if USE(ACCELERATED_COMPOSITING)
     3980    if (!renderer()->documentBeingDestroyed())
     3981        compositor()->setCompositingLayersNeedRebuild();
     3982#endif
    39963983}
    39973984

  • trunk/Source/WebCore/rendering/RenderLayer.h

    r98776 r98789  
    377377
    378378    void dirtyZOrderLists();
    379     void dirtyZOrderListsIncludingDescendants();
    380379    void dirtyStackingContextZOrderLists();
    381380    void updateZOrderLists();
    … …  
    542541    void setFirstChild(RenderLayer* first) { m_first = first; }
    543542    void setLastChild(RenderLayer* last) { m_last = last; }
    544    
    545     void dirtyZOrderListsInternal();
    546543
    547544    LayoutPoint renderBoxLocation() const { return renderer()->isBox() ? toRenderBox(renderer())->location() : LayoutPoint(); }

  • trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

    r98776 r98789  
    125125        if (m_compositing) {
    126126            ensureRootLayer();
    127             // Compositing affects whether visibility:hidden layers are included in z-order lists, so we have to dirty the lists here.
    128             rootRenderLayer()->dirtyZOrderListsIncludingDescendants();
    129127            notifyIFramesOfCompositingChange();
    130128        } else
    … …  
    11261124    }
    11271125}
     1126
    11281127
    11291128void RenderLayerCompositor::repaintCompositedLayersAbsoluteRect(const LayoutRect& absRect)
Note: See TracChangeset for help on using the changeset viewer.