Changeset 98796 in webkit

Timestamp:

Oct 28, 2011, 11:31:16 PM (15 years ago)

Author:

rniwa@webkit.org

Message:

Potential crash in ReplaceNodeWithSpanCommand
​https://bugs.webkit.org/show_bug.cgi?id=71145

Reviewed by Ojan Vafai.

Fix a potential crash without tests because we don't have a reduction.

• editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/ReplaceNodeWithSpanCommand.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-10-28  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Potential crash in ReplaceNodeWithSpanCommand
+        https://bugs.webkit.org/show_bug.cgi?id=71145
+
+        Reviewed by Ojan Vafai.
+
+        Fix a potential crash without tests because we don't have a reduction.
+
+        * editing/ReplaceNodeWithSpanCommand.cpp:
+        (WebCore::swapInNodePreservingAttributesAndChildren):
+
 2011-10-28  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp

@@ -53 +53 @@
     ASSERT(nodeToReplace->inDocument());
     ExceptionCode ec = 0;
-    ContainerNode* parentNode = nodeToReplace->parentNode();
+    RefPtr<ContainerNode> parentNode = nodeToReplace->parentNode();
     parentNode->insertBefore(newNode, nodeToReplace, ec);
     ASSERT(!ec);