Changeset 99381 in webkit

Timestamp:

Nov 6, 2011, 1:01:45 PM (15 years ago)

Author:

eric@webkit.org

Message:

Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
​https://bugs.webkit.org/show_bug.cgi?id=66078

Unreviewed. Add an assert about the type of "args"
to our Executive Mocks and fix a piece of code
from this patch which was hitting that assert
when executing for real.

• Scripts/webkitpy/common/system/executive_mock.py:
• Scripts/webkitpy/layout_tests/port/webkit.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/system/executive_mock.py (modified) (2 diffs)
• Scripts/webkitpy/layout_tests/port/webkit.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-11-06  Eric Seidel  <eric@webkit.org>
+
+        Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
+        https://bugs.webkit.org/show_bug.cgi?id=66078
+
+        Unreviewed.  Add an assert about the type of "args"
+        to our Executive Mocks and fix a piece of code
+        from this patch which was hitting that assert
+        when executing for real.
+
+        * Scripts/webkitpy/common/system/executive_mock.py:
+        * Scripts/webkitpy/layout_tests/port/webkit.py:
+
 2011-11-06  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py

@@ -60 +60 @@
                     return_stderr=True,
                     decode_output=False):
+        assert(isinstance(args, list) or isinstance(args, tuple))
         if self._should_log:
             log("MOCK run_command: %s, cwd=%s" % (args, cwd))
@@ -93 +94 @@
                     return_stderr=True,
                     decode_output=False):
+        assert(isinstance(args, list) or isinstance(args, tuple))
         if self._exception:
             raise self._exception

trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py

@@ -263 +263 @@
             return None
         try:
-            return self._executive.run_command('nm', webcore_library_path, error_handler=Executive.ignore_error)
+            return self._executive.run_command(['nm', webcore_library_path], error_handler=Executive.ignore_error)
         except OSError, e:
             _log.warn("Failed to run nm: %s.  Can't determine WebCore supported features." % e)