Changeset 99391 in webkit

Timestamp:

Nov 6, 2011, 6:34:40 PM (15 years ago)

Author:

keishi@webkit.org

Message:

Remove ColorInputType::handleClickEvent
​https://bugs.webkit.org/show_bug.cgi?id=71640

Reviewed by Kent Tamura.

When you click the input color element, both ColorInputType::handleClickEvent and
ColorInputType::handleDOMActivateEvent are called, causing Chrome::openColorChooser
to be called too many times.

• html/ColorInputType.cpp: Removed ColorInputType::handleClickEvent
• html/ColorInputType.h: Removed ColorInputType::handleClickEvent

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/ColorInputType.cpp (modified) (1 diff)
• html/ColorInputType.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-06  Keishi Hattori  <keishi@webkit.org>
+
+        Remove ColorInputType::handleClickEvent
+        https://bugs.webkit.org/show_bug.cgi?id=71640
+
+        Reviewed by Kent Tamura.
+
+        When you click the input color element, both ColorInputType::handleClickEvent and
+        ColorInputType::handleDOMActivateEvent are called, causing Chrome::openColorChooser
+        to be called too many times.
+
+        * html/ColorInputType.cpp: Removed ColorInputType::handleClickEvent
+        * html/ColorInputType.h: Removed ColorInputType::handleClickEvent
+
 2011-11-06  Keishi Hattori  <keishi@webkit.org>
 

trunk/Source/WebCore/html/ColorInputType.cpp

@@ -133 +133 @@
 }
 
-void ColorInputType::handleClickEvent(MouseEvent* event)
-{
-    if (event->isSimulated())
-        return;
-
-    if (element()->disabled() || element()->readOnly())
-        return;
-
-    if (Chrome* chrome = this->chrome()) {
-        ColorChooser::chooser()->connectClient(this);
-        chrome->openColorChooser(ColorChooser::chooser(), valueAsColor());
-    }
-    event->setDefaultHandled();
-}
-
 void ColorInputType::handleDOMActivateEvent(Event* event)
 {

trunk/Source/WebCore/html/ColorInputType.h

@@ -54 +54 @@
     virtual void createShadowSubtree();
     virtual void setValue(const String&, bool valueChanged, bool sendChangeEvent);
-    virtual void handleClickEvent(MouseEvent*);
     virtual void handleDOMActivateEvent(Event*);
     virtual void detach();