Changeset 99780 in webkit

Timestamp:

Nov 9, 2011, 4:11:52 PM (15 years ago)

Author:

dominicc@chromium.org

Message:

Remove WebGLContextEvent.initEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71720

Reviewed by Adam Barth.

The WebGL spec calls this method initWebGLContextEvent, but it may
adopt a constructor instead. Deleting the initEvent method for now
since it is definitely wrong and we don't want people to come to
depend on it.

No new tests--removing untested code.

• html/canvas/WebGLContextEvent.cpp:
• html/canvas/WebGLContextEvent.h:
• html/canvas/WebGLContextEvent.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/canvas/WebGLContextEvent.cpp (modified) (1 diff)
• html/canvas/WebGLContextEvent.h (modified) (1 diff)
• html/canvas/WebGLContextEvent.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-09  Dominic Cooney  <dominicc@chromium.org>
+
+        Remove WebGLContextEvent.initEvent method
+        https://bugs.webkit.org/show_bug.cgi?id=71720
+
+        Reviewed by Adam Barth.
+
+        The WebGL spec calls this method initWebGLContextEvent, but it may
+        adopt a constructor instead. Deleting the initEvent method for now
+        since it is definitely wrong and we don't want people to come to
+        depend on it.
+
+        No new tests--removing untested code.
+
+        * html/canvas/WebGLContextEvent.cpp:
+        * html/canvas/WebGLContextEvent.h:
+        * html/canvas/WebGLContextEvent.idl:
+
 2011-11-09  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/html/canvas/WebGLContextEvent.cpp

@@ -45 +45 @@
 }
 
-void WebGLContextEvent::initEvent(const AtomicString& type, bool canBubble, bool cancelable, const String& statusMessage)
-{
-    if (dispatched())
-        return;
-
-    Event::initEvent(type, canBubble, cancelable);
-    m_statusMessage = statusMessage;
-}
-
 const AtomicString& WebGLContextEvent::interfaceName() const
 {

trunk/Source/WebCore/html/canvas/WebGLContextEvent.h

@@ -43 +43 @@
     virtual ~WebGLContextEvent();
 
-    void initEvent(const AtomicString& type, bool canBubble, bool cancelable, const String& statusMessage);
-
     const String& statusMessage() const { return m_statusMessage; }
 

trunk/Source/WebCore/html/canvas/WebGLContextEvent.idl

@@ -29 +29 @@
     ] WebGLContextEvent : Event {
         readonly attribute DOMString statusMessage;
-        [StrictTypeChecking] void initEvent(in [Optional=CallWithDefaultValue] DOMString eventTypeArg,
-                                            in [Optional=CallWithDefaultValue] boolean canBubbleArg,
-                                            in [Optional=CallWithDefaultValue] boolean cancelableArg,
-                                            in [Optional=CallWithDefaultValue] DOMString statusMessageArg);
     };
 }