⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 99821 in webkit


Ignore:
Timestamp:
Nov 10, 2011, 12:17:27 AM (15 years ago)
Author:
loislo@chromium.org
Message:

Unreviewed, rolling out r99816.
​http://trac.webkit.org/changeset/99816
​https://bugs.webkit.org/show_bug.cgi?id=72003

compilation failed on mac (Requested by loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-11-10

Source/WebCore:

  • html/HTMLAttributeNames.in:
  • html/HTMLInputElement.idl:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData):

  • html/HTMLTextAreaElement.idl:
  • html/HTMLTextFormControlElement.cpp:
  • html/HTMLTextFormControlElement.h:
  • html/TextFieldInputType.cpp:
  • html/TextFieldInputType.h:

LayoutTests:

  • fast/forms/form-dirname-attribute-expected.txt: Removed.
  • fast/forms/form-dirname-attribute.html: Removed.
  • fast/forms/submit-form-with-dirname-attribute-expected.txt: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Removed.
  • fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Removed.
  • fast/forms/submit-form-with-dirname-attribute.html: Removed.
Location:
trunk
Files:
8 deleted
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r99820 r99821  
     12011-11-10  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r99816.
     4        http://trac.webkit.org/changeset/99816
     5        https://bugs.webkit.org/show_bug.cgi?id=72003
     6
     7        compilation failed on mac (Requested by loislo on #webkit).
     8
     9        * fast/forms/form-dirname-attribute-expected.txt: Removed.
     10        * fast/forms/form-dirname-attribute.html: Removed.
     11        * fast/forms/submit-form-with-dirname-attribute-expected.txt: Removed.
     12        * fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Removed.
     13        * fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Removed.
     14        * fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Removed.
     15        * fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Removed.
     16        * fast/forms/submit-form-with-dirname-attribute.html: Removed.
     17
    1182011-11-10  Yuta Kitamura  <yutak@chromium.org>
    219

  • trunk/Source/WebCore/ChangeLog

    r99819 r99821  
     12011-11-10  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r99816.
     4        http://trac.webkit.org/changeset/99816
     5        https://bugs.webkit.org/show_bug.cgi?id=72003
     6
     7        compilation failed on mac (Requested by loislo on #webkit).
     8
     9        * html/HTMLAttributeNames.in:
     10        * html/HTMLInputElement.idl:
     11        * html/HTMLTextAreaElement.cpp:
     12        (WebCore::HTMLTextAreaElement::appendFormData):
     13        * html/HTMLTextAreaElement.idl:
     14        * html/HTMLTextFormControlElement.cpp:
     15        * html/HTMLTextFormControlElement.h:
     16        * html/TextFieldInputType.cpp:
     17        * html/TextFieldInputType.h:
     18
    1192011-11-09  Pavel Feldman  <pfeldman@google.com>
    220

  • trunk/Source/WebCore/html/HTMLAttributeNames.in

    r99816 r99821  
    9191dir
    9292direction
    93 dirname
    9493disabled
    9594download

  • trunk/Source/WebCore/html/HTMLInputElement.idl

    r99816 r99821  
    2424        attribute [ConvertNullToNullString] DOMString defaultValue;
    2525        attribute [Reflect=checked] boolean defaultChecked;
    26         attribute [Reflect] DOMString dirName;
    2726        readonly attribute HTMLFormElement form;
    2827        attribute [Reflect, URL] DOMString formAction;

  • trunk/Source/WebCore/html/HTMLTextAreaElement.cpp

    r99816 r99821  
    174174    const String& text = (m_wrap == HardWrap) ? valueWithHardLineBreaks() : value();
    175175    encoding.appendData(name(), text);
    176 
    177     const AtomicString& dirnameAttrValue = fastGetAttribute(dirnameAttr);
    178     if (!dirnameAttrValue.isNull())
    179         encoding.appendData(dirnameAttrValue, directionForFormData());
    180     return true;   
     176    return true;
    181177}
    182178

  • trunk/Source/WebCore/html/HTMLTextAreaElement.idl

    r99816 r99821  
    2828        attribute [Reflect] DOMString accessKey;
    2929        attribute long cols;
    30         attribute [Reflect] DOMString dirName;
    3130        attribute [Reflect] boolean disabled;
    3231        attribute [Reflect] boolean autofocus;

  • trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp

    r99816 r99821  
    571571}
    572572
    573 const Element* parentHTMLElement(const Element* element)
    574 {
    575     while (element) {
    576         element = element->parentElement();
    577         if (element && element->isHTMLElement())
    578             return element;
    579     }
    580     return 0;
    581 }
    582 
    583 String HTMLTextFormControlElement::directionForFormData() const
    584 {
    585     for (const Element* element = this; element; element = parentHTMLElement(element)) {
    586         const AtomicString& dirAttributeValue = element->fastGetAttribute(dirAttr);
    587         if (dirAttributeValue.isNull())
    588             continue;
    589 
    590         if (equalIgnoringCase(dirAttributeValue, "rtl") || equalIgnoringCase(dirAttributeValue, "ltr"))
    591             return dirAttributeValue;
    592 
    593         if (equalIgnoringCase(dirAttributeValue, "auto")) {
    594             bool isAuto;
    595             TextDirection textDirection = static_cast<const HTMLElement*>(element)->directionalityIfhasDirAutoAttribute(isAuto);
    596             return textDirection == RTL ? "rtl" : "ltr";
    597         }
    598     }
    599 
    600     return "ltr";
    601 }
    602 
    603573} // namespace Webcore

  • trunk/Source/WebCore/html/HTMLTextFormControlElement.h

    r99816 r99821  
    8080    String innerTextValue() const;
    8181
    82     String directionForFormData() const;
    83 
    8482protected:
    8583    HTMLTextFormControlElement(const QualifiedName&, Document*, HTMLFormElement*);

  • trunk/Source/WebCore/html/TextFieldInputType.cpp

    r99816 r99821  
    3434
    3535#include "BeforeTextInsertedEvent.h"
    36 #include "FormDataList.h"
    3736#include "Frame.h"
    3837#include "HTMLInputElement.h"
    39 #include "HTMLNames.h"
    4038#include "KeyboardEvent.h"
    4139#include "Page.h"
    … …  
    5250namespace WebCore {
    5351
    54 using namespace HTMLNames;
    55 
    5652TextFieldInputType::TextFieldInputType(HTMLInputElement* element)
    5753    : InputType(element)
    … …  
    369365}
    370366
    371 bool TextFieldInputType::appendFormData(FormDataList& list, bool multipart) const
    372 {
    373     InputType::appendFormData(list, multipart);
    374     const AtomicString& dirnameAttrValue = element()->fastGetAttribute(dirnameAttr);
    375     if (!dirnameAttrValue.isNull())
    376         list.appendData(dirnameAttrValue, element()->directionForFormData());
    377     return true;
    378 }
    379 
    380367} // namespace WebCore

  • trunk/Source/WebCore/html/TextFieldInputType.h

    r99816 r99821  
    3636namespace WebCore {
    3737
    38 class FormDataList;
    3938class SpinButtonElement;
    4039
    … …  
    7978    virtual HTMLElement* placeholderElement() const;
    8079    virtual void updatePlaceholderText();
    81     virtual bool appendFormData(FormDataList&, bool multipart) const;
    8280
    8381    RefPtr<HTMLElement> m_container;
Note: See TracChangeset for help on using the changeset viewer.