Changeset 103866 in webkit


Ignore:
Timestamp:
Dec 31, 2011, 4:58:20 PM (13 years ago)
Author:
mitz@apple.com
Message:

MiniBrowser sets the WKView’s frame incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=75393

Reviewed by Anders Carlsson.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,

which is not needed since the binray is linked with the frameworks search path set to the
built products directory.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
container’s bounds rather than its frame.

  • MiniBrowser/mac/make-launchable.sh: Removed.
Location:
trunk/Tools
Files:
1 deleted
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r103834 r103866  
     12011-12-31  Dan Bernstein  <mitz@apple.com>
     2
     3        MiniBrowser sets the WKView’s frame incorrectly
     4        https://bugs.webkit.org/show_bug.cgi?id=75393
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
     9        which is not needed since the binray is linked with the frameworks search path set to the
     10        built products directory.
     11        * MiniBrowser/mac/BrowserWindowController.m:
     12        (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
     13        container’s bounds rather than its frame.
     14        * MiniBrowser/mac/make-launchable.sh: Removed.
     15
    1162011-12-29  Dan Bernstein  <mitz@apple.com>
    217

  • trunk/Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj

    r82141 r103866  
    6262                51E244F911EFCE07008228D1 /* MBToolbarItem.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = MBToolbarItem.m; sourceTree = "<group>"; };
    6363                8D1107320486CEB800E47090 /* MiniBrowser.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = MiniBrowser.app; sourceTree = BUILT_PRODUCTS_DIR; };
    64                 BC1770121188DF19007D9E9A /* make-launchable.sh */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.sh; name = "make-launchable.sh"; path = "mac/make-launchable.sh"; sourceTree = "<group>"; };
    6564                BC329486116A92E2008635D0 /* main.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = main.m; path = mac/main.m; sourceTree = "<group>"; };
    6665                BC329496116A941B008635D0 /* BrowserWindowController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = BrowserWindowController.h; path = mac/BrowserWindowController.h; sourceTree = "<group>"; };
    … …  
    158157                                29B97317FDCFA39411CA2CEA /* Resources */,
    159158                                BCA8CBDA11E5787800812FB7 /* Configurations */,
    160                                 BC1770481188EB05007D9E9A /* Scripts */,
    161159                                29B97323FDCFA39411CA2CEA /* Frameworks */,
    162160                                19C28FACFE9D520D11CA2CBB /* Products */,
    … …  
    182180                        );
    183181                        name = Frameworks;
    184                         sourceTree = "<group>";
    185                 };
    186                 BC1770481188EB05007D9E9A /* Scripts */ = {
    187                         isa = PBXGroup;
    188                         children = (
    189                                 BC1770121188DF19007D9E9A /* make-launchable.sh */,
    190                         );
    191                         name = Scripts;
    192182                        sourceTree = "<group>";
    193183                };
    … …  
    224214                                8D11072C0486CEB800E47090 /* Sources */,
    225215                                8D11072E0486CEB800E47090 /* Frameworks */,
    226                                 BC17701E1188DFB4007D9E9A /* Make Launchable */,
    227216                        );
    228217                        buildRules = (
    … …  
    299288/* End PBXResourcesBuildPhase section */
    300289
    301 /* Begin PBXShellScriptBuildPhase section */
    302                 BC17701E1188DFB4007D9E9A /* Make Launchable */ = {
    303                         isa = PBXShellScriptBuildPhase;
    304                         buildActionMask = 2147483647;
    305                         files = (
    306                         );
    307                         inputPaths = (
    308                         );
    309                         name = "Make Launchable";
    310                         outputPaths = (
    311                         );
    312                         runOnlyForDeploymentPostprocessing = 0;
    313                         shellPath = /bin/sh;
    314                         shellScript = "mac/make-launchable.sh\n";
    315                 };
    316 /* End PBXShellScriptBuildPhase section */
    317 
    318290/* Begin PBXSourcesBuildPhase section */
    319291                8D11072C0486CEB800E47090 /* Sources */ = {

  • trunk/Tools/MiniBrowser/mac/BrowserWindowController.m

    r102352 r103866  
    575575- (void)awakeFromNib
    576576{
    577     _webView = [[WKView alloc] initWithFrame:[containerView frame] contextRef:_context pageGroupRef:_pageGroup];
    578 
     577    _webView = [[WKView alloc] initWithFrame:[containerView bounds] contextRef:_context pageGroupRef:_pageGroup];
     578
     579    [_webView setAutoresizingMask:(NSViewWidthSizable | NSViewHeightSizable)];
    579580    [containerView addSubview:_webView];
    580     [_webView setFrame:[containerView frame]];
    581    
    582     [_webView setAutoresizingMask:(NSViewWidthSizable | NSViewHeightSizable)];
    583581   
    584582    WKPageLoaderClient loadClient = {
Note: See TracChangeset for help on using the changeset viewer.