Changeset 103910 in webkit

Timestamp:

Jan 2, 2012, 11:18:01 AM (13 years ago)

Author:

mitz@apple.com

Message:

[mac] Remove -[WebView setHoverFeedbackSuspended:]
​https://bugs.webkit.org/show_bug.cgi?id=75406

Reviewed by Tim Hatcher.

• WebView/WebHTMLView.mm:

(-[WebHTMLView _updateMouseoverWithEvent:]): Removed check for suspended hover updates.

• WebView/WebHTMLViewInternal.h: Removed -_hoverFeedbackSuspendedChanged.
• WebView/WebView.mm:

(-[WebView setHoverFeedbackSuspended:]): Left empty implementation to support versions of
Safari that call this.
(-[WebView isHoverFeedbackSuspended]): Left implementation that always returns NO to support
versions of Safari that call this.

• WebView/WebViewData.h: Removed hoverFeedbackSuspended ivar.
• WebView/WebViewPrivate.h: Removed method definitions.

Location:

trunk/Source/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebHTMLView.mm (modified) (2 diffs)
• WebView/WebHTMLViewInternal.h (modified) (1 diff)
• WebView/WebView.mm (modified) (1 diff)
• WebView/WebViewData.h (modified) (1 diff)
• WebView/WebViewPrivate.h (modified) (1 diff)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2012-01-02  Dan Bernstein  <mitz@apple.com>
+
+        [mac] Remove -[WebView setHoverFeedbackSuspended:]
+        https://bugs.webkit.org/show_bug.cgi?id=75406
+
+        Reviewed by Tim Hatcher.
+
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView _updateMouseoverWithEvent:]): Removed check for suspended hover updates.
+        * WebView/WebHTMLViewInternal.h: Removed -_hoverFeedbackSuspendedChanged.
+        * WebView/WebView.mm:
+        (-[WebView setHoverFeedbackSuspended:]): Left empty implementation to support versions of
+        Safari that call this.
+        (-[WebView isHoverFeedbackSuspended]): Left implementation that always returns NO to support
+        versions of Safari that call this.
+        * WebView/WebViewData.h: Removed hoverFeedbackSuspended ivar.
+        * WebView/WebViewPrivate.h: Removed method definitions.
+
 2011-12-31  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebHTMLView.mm

@@ -1559 +1559 @@
     
     WebHTMLView *view = nil;
-    if ([hitView isKindOfClass:[WebHTMLView class]] && ![[(WebHTMLView *)hitView _webView] isHoverFeedbackSuspended])
+    if ([hitView isKindOfClass:[WebHTMLView class]])
         view = (WebHTMLView *)hitView;    
 
@@ -5259 +5259 @@
 }
 
-- (void)_hoverFeedbackSuspendedChanged
-{
-    [self _updateMouseoverWithFakeEvent];
-}
-
 - (void)_executeSavedKeypressCommands
 {

trunk/Source/WebKit/mac/WebView/WebHTMLViewInternal.h

@@ -49 +49 @@
 - (WebFrame *)_frame;
 - (void)_lookUpInDictionaryFromMenu:(id)sender;
-- (void)_hoverFeedbackSuspendedChanged;
 - (BOOL)_interpretKeyEvent:(WebCore::KeyboardEvent *)event savingCommands:(BOOL)savingCommands;
 - (DOMDocumentFragment *)_documentFragmentFromPasteboard:(NSPasteboard *)pasteboard;

trunk/Source/WebKit/mac/WebView/WebView.mm

@@ -4606 +4606 @@
 }
 
+#if defined(BUILDING_ON_SNOW_LEOPARD) || defined(BUILDING_ON_LION)
+// FIXME: Remove once WebKit no longer needs to support versions of Safari that call this.
 - (void)setHoverFeedbackSuspended:(BOOL)newValue
 {
-    if (_private->hoverFeedbackSuspended == newValue)
-        return;
-    
-    _private->hoverFeedbackSuspended = newValue;
-
-    id <WebDocumentView> documentView = [[[self mainFrame] frameView] documentView];
-    // FIXME: in a perfect world we'd do this in a general way that worked with any document view,
-    // such as by calling a protocol method or using respondsToSelector or sending a notification.
-    // But until there is any need for these more general solutions, we'll just hardwire it to work
-    // with WebHTMLView.
-    // Note that _hoverFeedbackSuspendedChanged needs to be called only on the main WebHTMLView, not
-    // on each subframe separately.
-    if ([documentView isKindOfClass:[WebHTMLView class]])
-        [(WebHTMLView *)documentView _hoverFeedbackSuspendedChanged];
-}
-
+}
+
+// FIXME: Remove once WebKit no longer needs to support versions of Safari that call this.
 - (BOOL)isHoverFeedbackSuspended
 {
-    return _private->hoverFeedbackSuspended;
-}
+    return NO;
+}
+#endif
 
 - (void)setMainFrameDocumentReady:(BOOL)mainFrameDocumentReady

trunk/Source/WebKit/mac/WebView/WebViewData.h

@@ -134 +134 @@
     BOOL becomingFirstResponder;
     BOOL becomingFirstResponderFromOutside;
-    BOOL hoverFeedbackSuspended;
     BOOL usesPageCache;
     BOOL catchesDelegateExceptions;

trunk/Source/WebKit/mac/WebView/WebViewPrivate.h

@@ -133 +133 @@
 - (void)scrollDOMRangeToVisible:(DOMRange *)range;
 
-// setHoverFeedbackSuspended: can be called by clients that want to temporarily prevent the webView
-// from displaying feedback about mouse position. Each WebDocumentView class that displays feedback
-// about mouse position should honor this setting.
-- (void)setHoverFeedbackSuspended:(BOOL)newValue;
-- (BOOL)isHoverFeedbackSuspended;
-
 /*!
 @method setScriptDebugDelegate: