Changeset 105005 in webkit


Ignore:
Timestamp:
Jan 13, 2012 3:56:26 PM (12 years ago)
Author:
mitz@apple.com
Message:

REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots
https://bugs.webkit.org/show_bug.cgi?id=76254

Reviewed by Anders Carlsson.

Source/WebCore:

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired): Added a call to
CachedResourceLoader::loadDone() after decrementing the request count. This allows the
frame loader to see that the request count is zero and dispatch didFinishLoad.

LayoutTests:

  • svg/custom/pointer-events-invalid-fill.svg: Force layout before sending a mouse event.

Otherwise, the WebHTMLView may have zero size, causing the hit test in
-[EventSendingController mouseMoveToX:Y:] to yield the clip view and the event to go nowhere.

  • svg/custom/resources/use-instanceRoot-event-listeners.js: Ditto.
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r105000 r105005  
     12012-01-13  Dan Bernstein  <mitz@apple.com>
     2
     3        REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots
     4        https://bugs.webkit.org/show_bug.cgi?id=76254
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * svg/custom/pointer-events-invalid-fill.svg: Force layout before sending a mouse event.
     9        Otherwise, the WebHTMLView may have zero size, causing the hit test in
     10        -[EventSendingController mouseMoveToX:Y:] to yield the clip view and the event to go nowhere.
     11        * svg/custom/resources/use-instanceRoot-event-listeners.js: Ditto.
     12
    1132012-01-13  Nate Chapin  <japhet@chromium.org>
    214
  • trunk/LayoutTests/svg/custom/pointer-events-invalid-fill.svg

    r89490 r105005  
    6565      function runTest() {
    6666        if (window.eventSender) {
     67          document.documentElement.offsetLeft;
    6768          eventSender.mouseMoveTo(30, 100);
    6869        }
  • trunk/LayoutTests/svg/custom/resources/use-instanceRoot-event-listeners.js

    r75408 r105005  
    172172// Start tests
    173173if (window.eventSender) {
     174    document.documentElement.offsetLeft;
    174175    eventSender.mouseMoveTo(115, 55);
    175176    driveTests();
  • trunk/Source/WebCore/ChangeLog

    r105004 r105005  
     12012-01-13  Dan Bernstein  <mitz@apple.com>
     2
     3        REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots
     4        https://bugs.webkit.org/show_bug.cgi?id=76254
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * css/CSSFontSelector.cpp:
     9        (WebCore::CSSFontSelector::beginLoadTimerFired): Added a call to
     10        CachedResourceLoader::loadDone() after decrementing the request count. This allows the
     11        frame loader to see that the request count is zero and dispatch didFinishLoad.
     12
    1132012-01-13  Jer Noble  <jer.noble@apple.com>
    214
  • trunk/Source/WebCore/css/CSSFontSelector.cpp

    r104542 r105005  
    616616        cachedResourceLoader->decrementRequestCount(fontsToBeginLoading[i].get());
    617617    }
    618 }
    619 
    620 }
     618    // Ensure that if the request count reaches zero, the frame loader will know about it.
     619    cachedResourceLoader->loadDone();
     620}
     621
     622}
Note: See TracChangeset for help on using the changeset viewer.