Changeset 106310 in webkit


Ignore:
Timestamp:
Jan 30, 2012 5:57:37 PM (12 years ago)
Author:
mitz@apple.com
Message:

<rdar://problem/10778045> REGRESSION (r91935): text-combine fails
https://bugs.webkit.org/show_bug.cgi?id=77373

Reviewed by Darin Adler.

Source/WebCore:

Removed tests that were failing because of this bug from the Lion skipped
list.

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill): Changed to use CTFontGetGlyphsForCharacters,
rather than wkGetVerticalGlyphsForCharacters, for non-fullwidth fonts.

LayoutTests:

Removed tests that were failing because of this bug from the skipped list.

  • platform/mac-lion/Skipped:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r106309 r106310  
     12012-01-30  Dan Bernstein  <mitz@apple.com>
     2
     3        <rdar://problem/10778045> REGRESSION (r91935): text-combine fails
     4        https://bugs.webkit.org/show_bug.cgi?id=77373
     5
     6        Reviewed by Darin Adler.
     7
     8        Removed tests that were failing because of this bug from the skipped list.
     9
     10        * platform/mac-lion/Skipped:
     11
    1122012-01-30  Brady Eidson  <beidson@apple.com>
    213
  • trunk/LayoutTests/platform/mac-lion/Skipped

    r106184 r106310  
    122122# --- Misc failures that need investigation ---
    123123
    124 # These fail in DRT but look correct in Safari.
    125 fast/text/emphasis-combined-text.html
    126 fast/text/international/text-combine-image-test.html
    127 
    128124# Sending the mouse down event to the scrollbar starts a nested run loop which causes a hang.
    129125fast/events/mousedown-in-subframe-scrollbar.html
  • trunk/Source/WebCore/ChangeLog

    r106307 r106310  
     12012-01-30  Dan Bernstein  <mitz@apple.com>
     2
     3        <rdar://problem/10778045> REGRESSION (r91935): text-combine fails
     4        https://bugs.webkit.org/show_bug.cgi?id=77373
     5
     6        Reviewed by Darin Adler.
     7
     8        Removed tests that were failing because of this bug from the Lion skipped
     9        list.
     10
     11        * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
     12        (WebCore::GlyphPage::fill): Changed to use CTFontGetGlyphsForCharacters,
     13        rather than wkGetVerticalGlyphsForCharacters, for non-fullwidth fonts.
     14
    1152012-01-30  Christopher Hutten-Czapski  <chutten@rim.com>
    216
  • trunk/Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp

    r91935 r106310  
    6565            }
    6666        }
    67     } else if (wkGetVerticalGlyphsForCharacters(fontData->platformData().ctFont(), buffer, glyphs.data(), bufferLength)) {
     67    } else if ((fontData->platformData().widthVariant() == RegularWidth) ? wkGetVerticalGlyphsForCharacters(fontData->platformData().ctFont(), buffer, glyphs.data(), bufferLength)
     68        : CTFontGetGlyphsForCharacters(fontData->platformData().ctFont(), buffer, glyphs.data(), bufferLength)) {
    6869        for (unsigned i = 0; i < length; ++i) {
    6970            if (!glyphs[i])
Note: See TracChangeset for help on using the changeset viewer.