Changeset 110480 in webkit

Timestamp:

Mar 12, 2012, 2:33:48 PM (13 years ago)

Author:

Beth Dakin

Message:

​https://bugs.webkit.org/show_bug.cgi?id=80888
Clear background for NSTextFieldCell is unreliable and not necessary
-and corresponding-
<rdar://problem/10663710>

Reviewed by Dan Bernstein.

With ​http://trac.webkit.org/changeset/104240 I thought it was necessary to
make NSTextFieldCells draw with a clear background in order to allow styled
text fields. That is not actually necessary; we just had a different bug
where isControlStyled() was only checking for styled borders on text fields.
Text fields can also be styled with backgrounds, so they need the full check.

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::textField):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderThemeMac.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog ¶

@@ +1 @@
+2012-03-12  Beth Dakin  <bdakin@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=80888
+        Clear background for NSTextFieldCell is unreliable and not necessary
+        -and corresponding-
+        <rdar://problem/10663710>
+
+        Reviewed by Dan Bernstein.
+
+        With http://trac.webkit.org/changeset/104240 I thought it was necessary to 
+        make NSTextFieldCells draw with a clear background in order to allow styled 
+        text fields. That is not actually necessary; we just had a different bug 
+        where isControlStyled() was only checking for styled borders on text fields. 
+        Text fields can also be styled with backgrounds, so they need the full check.
+        * rendering/RenderThemeMac.mm:
+        (WebCore::RenderThemeMac::isControlStyled):
+        (WebCore::RenderThemeMac::textField):
+
 2012-03-12  Scott Byer  <scottbyer@chromium.org>
 

trunk/Source/WebCore/rendering/RenderThemeMac.mm ¶

@@ -488 +488 @@
                                      const FillLayer& background, const Color& backgroundColor) const
 {
-    if (style->appearance() == TextFieldPart || style->appearance() == TextAreaPart || style->appearance() == ListboxPart)
+    if (style->appearance() == TextAreaPart || style->appearance() == ListboxPart)
         return style->border() != border;
         
@@ -2138 +2138 @@
         [m_textField.get() setEditable:YES];
         [m_textField.get() setFocusRingType:NSFocusRingTypeExterior];
-
-        // Setting a clear background on the cell is necessary for CSS-styled backgrounds
-        // to show through. Ideally, there would be a better way to do this.
-        [m_textField.get() setDrawsBackground:YES];
-        [m_textField.get() setBackgroundColor:[NSColor clearColor]];
     }