Changeset 111884 in webkit

Timestamp:

Mar 23, 2012, 11:34:31 AM (13 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/7883987> ASSERTION FAILED: ASSERT(input == AnimationStateInputEndTimerFired

input == AnimationStateInputPlayStatePaused) in AnimationBase::updateStateMachine causing multiple "crashes" on Lion Intel Debug WebKit testers

​https://bugs.webkit.org/show_bug.cgi?id=81351

Rubber-stamped by Jessie Berlin.

• page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine): Replaced the assertion with a LOG_ERROR so that
the issue is still noticeable, but it does not automatically make the debug bots red.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/animation/AnimationBase.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-23  Dan Bernstein  <mitz@apple.com>
+
+        <rdar://problem/7883987> ASSERTION FAILED: ASSERT(input == AnimationStateInputEndTimerFired || input == AnimationStateInputPlayStatePaused) in AnimationBase::updateStateMachine causing multiple "crashes" on Lion Intel Debug WebKit testers
+        https://bugs.webkit.org/show_bug.cgi?id=81351
+
+        Rubber-stamped by Jessie Berlin.
+
+        * page/animation/AnimationBase.cpp:
+        (WebCore::AnimationBase::updateStateMachine): Replaced the assertion with a LOG_ERROR so that
+        the issue is still noticeable, but it does not automatically make the debug bots red.
+
 2012-03-23  Mike Lawther  <mikelawther@chromium.org>
 

trunk/Source/WebCore/page/animation/AnimationBase.cpp

@@ -1495 +1495 @@
             break;
         case AnimationStateEnding:
-            ASSERT(input == AnimationStateInputEndTimerFired || input == AnimationStateInputPlayStatePaused);
-
+#if !LOG_DISABLED
+            if (input != AnimationStateInputEndTimerFired && input != AnimationStateInputPlayStatePaused)
+                LOG_ERROR("State is AnimationStateEnding, but input is not AnimationStateInputEndTimerFired or AnimationStateInputPlayStatePaused. It is %d.", input);
+#endif
             if (input == AnimationStateInputEndTimerFired) {