Changeset 113260 in webkit

Timestamp:

Apr 4, 2012, 4:23:28 PM (13 years ago)

Author:

mitz@apple.com

Message:

Paginated webviews render nothing in their gutters
​https://bugs.webkit.org/show_bug.cgi?id=83231

Reviewed by Adele Peterson.

When the RenderView has columns, nothing draws in the gutters.

• page/FrameView.cpp:

(WebCore::FrameView::paintContents): Paint the background color behind everything when
paginated.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-04-04  Dan Bernstein  <mitz@apple.com>
+
+        Paginated webviews render nothing in their gutters
+        https://bugs.webkit.org/show_bug.cgi?id=83231
+
+        Reviewed by Adele Peterson.
+
+        When the RenderView has columns, nothing draws in the gutters.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::paintContents): Paint the background color behind everything when
+        paginated.
+
 2012-04-04  Mark Pilgrim  <pilgrim@chromium.org>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -2974 +2974 @@
 #endif
 
+    Page* page = m_frame->page();
+    if (page->mainFrame() == m_frame && page->pagination().mode != Page::Pagination::Unpaginated)
+        p->fillRect(rect, baseBackgroundColor(), ColorSpaceDeviceRGB);
+
     bool isTopLevelPainter = !sCurrentPaintTimeStamp;
     if (isTopLevelPainter)