Changeset 122636 in webkit

Timestamp:

Jul 13, 2012 3:37:58 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Refactor RenderTable to use the section's iteration functions.
​https://bugs.webkit.org/show_bug.cgi?id=89751

Patch by Arpita Bahuguna <​arpitabahuguna@gmail.com> on 2012-07-13
Reviewed by Julien Chaffraix.

Removing anti-pattern wherever possible from RenderTable code. Also, modifying
RenderTable sections' iterations to use helper functions.

No new tests required for this change since no change in behavior is expected.

• rendering/RenderTable.cpp:

(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::setCellLogicalWidths):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):
Removed anti-patterns involving iterations over RenderObjects.

(WebCore::RenderTable::outerBorderAfter):
Modified RenderTable sections' iteration to use helper functions.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderTable.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-13  Arpita Bahuguna  <arpitabahuguna@gmail.com>
+
+        Refactor RenderTable to use the section's iteration functions.
+        https://bugs.webkit.org/show_bug.cgi?id=89751
+
+        Reviewed by Julien Chaffraix.
+
+        Removing anti-pattern wherever possible from RenderTable code. Also, modifying
+        RenderTable sections' iterations to use helper functions.
+
+        No new tests required for this change since no change in behavior is expected.
+
+        * rendering/RenderTable.cpp:
+        (WebCore::RenderTable::addOverflowFromChildren):
+        (WebCore::RenderTable::setCellLogicalWidths):
+        (WebCore::RenderTable::outerBorderStart):
+        (WebCore::RenderTable::outerBorderEnd):
+        Removed anti-patterns involving iterations over RenderObjects.
+
+        (WebCore::RenderTable::outerBorderAfter):
+        Modified RenderTable sections' iteration to use helper functions.
+
 2012-07-13  Enrica Casucci  <enrica@apple.com>
 

trunk/Source/WebCore/rendering/RenderTable.cpp

@@ -522 +522 @@
 
     // Add overflow from our sections.
-    for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {
-        if (child->isTableSection()) {
-            RenderTableSection* section = toRenderTableSection(child);
-            addOverflowFromChild(section);
-        }
-    }
+    for (RenderTableSection* section = topSection(); section; section = sectionBelow(section))
+        addOverflowFromChild(section);
 }
 
 void RenderTable::setCellLogicalWidths()
 {
-    for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {
-        if (child->isTableSection())
-            toRenderTableSection(child)->setCellLogicalWidths();
-    }
+    for (RenderTableSection* section = topSection(); section; section = sectionBelow(section))
+        section->setCellLogicalWidths();
 }
 
@@ -1001 +995 @@
         return 0;
     int borderWidth = 0;
-    RenderTableSection* bottomSection;
-    if (m_foot)
-        bottomSection = m_foot;
-    else {
-        RenderObject* child;
-        for (child = lastChild(); child && !child->isTableSection(); child = child->previousSibling()) { }
-        bottomSection = child ? toRenderTableSection(child) : 0;
-    }
-    if (bottomSection) {
-        borderWidth = bottomSection->outerBorderAfter();
+
+    if (RenderTableSection* section = bottomSection()) {
+        borderWidth = section->outerBorderAfter();
         if (borderWidth < 0)
-            return 0;   // Overridden by hidden
+            return 0; // Overridden by hidden
     }
     const BorderValue& tb = style()->borderAfter();
@@ -1036 +1023 @@
 
     bool allHidden = true;
-    for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {
-        if (!child->isTableSection())
-            continue;
-        int sw = toRenderTableSection(child)->outerBorderStart();
+    for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) {
+        int sw = section->outerBorderStart();
         if (sw < 0)
             continue;
@@ -1065 +1050 @@
 
     bool allHidden = true;
-    for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {
-        if (!child->isTableSection())
-            continue;
-        int sw = toRenderTableSection(child)->outerBorderEnd();
+    for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) {
+        int sw = section->outerBorderEnd();
         if (sw < 0)
             continue;