Changeset 122681 in webkit

Timestamp:

Jul 15, 2012, 1:15:10 PM (13 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/11875795> REGRESSION (tiled drawing): Page’s scroll bars flash with each character you type in a textarea (affects Wikipedia and YouTube)
​https://bugs.webkit.org/show_bug.cgi?id=91348

Reviewed by Anders Carlsson.

• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged): Added an early return if the scroll position
did not, in fact, change. This avoids the call to ScrollAnimator::notifyContentAreaScrolled,
which is what causes the scroll bars to flash.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ScrollableArea.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog ¶

@@ +1 @@
+2012-07-15  Dan Bernstein  <mitz@apple.com>
+
+        <rdar://problem/11875795> REGRESSION (tiled drawing): Page’s scroll bars flash with each character you type in a textarea (affects Wikipedia and YouTube)
+        https://bugs.webkit.org/show_bug.cgi?id=91348
+
+        Reviewed by Anders Carlsson.
+
+        * platform/ScrollableArea.cpp:
+        (WebCore::ScrollableArea::scrollPositionChanged): Added an early return if the scroll position
+        did not, in fact, change. This avoids the call to ScrollAnimator::notifyContentAreaScrolled,
+        which is what causes the scroll bars to flash.
+
 2012-07-14  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/platform/ScrollableArea.cpp ¶

@@ -143 +143 @@
 void ScrollableArea::scrollPositionChanged(const IntPoint& position)
 {
+    IntPoint oldPosition = scrollPosition();
     // Tell the derived class to scroll its contents.
     setScrollOffset(position);
+
+    if (scrollPosition() == oldPosition)
+        return;
 
     Scrollbar* verticalScrollbar = this->verticalScrollbar();