Changeset 124714 in webkit

Timestamp:

Aug 4, 2012 10:55:05 PM (12 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/11875795> REGRESSION (tiled drawing): Page’s scroll bars flash with each character you type in a textarea (affects Wikipedia and YouTube)
​https://bugs.webkit.org/show_bug.cgi?id=91348

Reviewed by Andy Estes.

• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged): Changed to call notifyContentAreaScrolled()
only if the scroll position after the change differs from what it was before the change.

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollPosition): Added an override of this ScrollableArea function.

• rendering/RenderListBox.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ScrollableArea.cpp (modified) (2 diffs)
• rendering/RenderListBox.cpp (modified) (1 diff)
• rendering/RenderListBox.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-04  Dan Bernstein  <mitz@apple.com>
+
+        <rdar://problem/11875795> REGRESSION (tiled drawing): Page’s scroll bars flash with each character you type in a textarea (affects Wikipedia and YouTube)
+        https://bugs.webkit.org/show_bug.cgi?id=91348
+
+        Reviewed by Andy Estes.
+
+        * platform/ScrollableArea.cpp:
+        (WebCore::ScrollableArea::scrollPositionChanged): Changed to call notifyContentAreaScrolled()
+        only if the scroll position after the change differs from what it was before the change.
+        * rendering/RenderListBox.cpp:
+        (WebCore::RenderListBox::scrollPosition): Added an override of this ScrollableArea function.
+        * rendering/RenderListBox.h:
+
 2012-08-04  Ami Fischman  <fischman@chromium.org>
 

trunk/Source/WebCore/platform/ScrollableArea.cpp

@@ -143 +143 @@
 void ScrollableArea::scrollPositionChanged(const IntPoint& position)
 {
+    IntPoint oldPosition = scrollPosition();
     // Tell the derived class to scroll its contents.
     setScrollOffset(position);
@@ -169 +170 @@
     }
 
-    scrollAnimator()->notifyContentAreaScrolled();
+    if (scrollPosition() != oldPosition)
+        scrollAnimator()->notifyContentAreaScrolled();
 }
 

trunk/Source/WebCore/rendering/RenderListBox.cpp

@@ -628 +628 @@
 }
 
+IntPoint RenderListBox::scrollPosition() const
+{
+    return IntPoint(0, m_indexOffset);
+}
+
 void RenderListBox::scrollTo(int newOffset)
 {

trunk/Source/WebCore/rendering/RenderListBox.h

@@ -101 +101 @@
     virtual int scrollPosition(Scrollbar*) const;
     virtual void setScrollOffset(const IntPoint&);
+    virtual IntPoint scrollPosition() const OVERRIDE;
     virtual void invalidateScrollbarRect(Scrollbar*, const IntRect&);
     virtual bool isActive() const;