Changeset 125979 in webkit


Ignore:
Timestamp:
Aug 19, 2012 12:12:28 PM (12 years ago)
Author:
mitz@apple.com
Message:

WebPageProxy::setCursor does not check that the view is still in an active window
https://bugs.webkit.org/show_bug.cgi?id=94427

Reviewed by Alexey Proskuryakov.

The Web process may ask to change the cursor when the view is in an active window, but
if by the time the UI process receives the message, the view is no longer in a window or the
window is not active , then the cursor should not change.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setCursor): Added a check that the view is in an active window before
allowing the page to change the cursor.

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r125978 r125979  
     12012-08-19  Dan Bernstein  <mitz@apple.com>
     2
     3        WebPageProxy::setCursor does not check that the view is still in an active window
     4        https://bugs.webkit.org/show_bug.cgi?id=94427
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        The Web process may ask to change the cursor when the view is in an active window, but
     9        if by the time the UI process receives the message, the view is no longer in a window or the
     10        window is not active , then the cursor should not change.
     11
     12        * UIProcess/WebPageProxy.cpp:
     13        (WebKit::WebPageProxy::setCursor): Added a check that the view is in an active window before
     14        allowing the page to change the cursor.
     15
    1162012-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
    217
  • trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

    r125930 r125979  
    31973197void WebPageProxy::setCursor(const WebCore::Cursor& cursor)
    31983198{
    3199     m_pageClient->setCursor(cursor);
     3199    // The Web process may have asked to change the cursor when the view was in an active window, but
     3200    // if it is no longer in a window or the window is not active, then the cursor should not change.
     3201    if (m_pageClient->isViewWindowActive())
     3202        m_pageClient->setCursor(cursor);
    32003203}
    32013204
Note: See TracChangeset for help on using the changeset viewer.