Changeset 128006 in webkit


Ignore:
Timestamp:
Sep 9, 2012, 5:29:21 PM (12 years ago)
Author:
eae@chromium.org
Message:

Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
​https://bugs.webkit.org/show_bug.cgi?id=81413

Reviewed by David Hyatt.

Source/WebCore:

Rename Node::getRect and getPixelSnappedRect to boundingBox and
pixelSnappedBoundingBox respectively.

Remove overridden getRect method from ContainerNode as it calculates the
same rect as the Node implementation but in a more complicated and
error-prone way. Also remove the getUpperLeftCorner/getLowerRightCorner
support functions as they are no longer needed.

No new tests, no change in functionality.

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySliderThumb::elementRect):
Update to call boundingBox.

  • dom/ContainerNode.cpp:
  • dom/ContainerNode.h:

Remove overridden getRect method and the getUpperLeftCorner/
getLowerRightCorner support methods .

  • dom/Element.cpp:

(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::Element::updateFocusAppearance):
Update to call boundingBox.

  • dom/Node.h:
  • dom/Node.cpp:

(WebCore::Node::boundingBox):
Rename getRect to boundingBox.

(WebCore::Node::pixelSnappedBoundingBox):
Rename getPixelSnappedRect to pixelSnappedBoundingBox.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::elementRectRelativeToRootView):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollElementToRect):
(WebCore::FrameView::scrollToAnchor):

  • page/SpatialNavigation.cpp:

(WebCore::nodeRectInAbsoluteCoordinates):
Update to call boundingBox/pixelSnappedBoundingBox.

Source/WebKit/chromium:

Update WebViewImpl to call boundingBox/pixelSnappedBoundingBox.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::applyAutofillSuggestions):
(WebKit::WebViewImpl::refreshAutofillPopup):

Source/WebKit/efl:

Update ewk_frame to call pixelSnappedBoundingBox.

  • ewk/ewk_frame.cpp:

(ewk_frame_focused_element_geometry_get):

Source/WebKit/gtk:

Update ChromeClientGtk and webkitwebview to call pixelSnappedBoundingBox.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::mouseDidMoveOverElement):

  • webkit/webkitwebview.cpp:

(getLocationForKeyboardGeneratedContextMenu):
(webkit_web_view_query_tooltip):

Source/WebKit/qt:

Update qwebelement and qwebpage to call pixelSnappedBoundingBox.

  • Api/qwebelement.cpp:

(QWebElement::geometry):
(QWebElement::render):

  • Api/qwebpage.cpp:

(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):

Source/WebKit2:

Update WebPage to call pixelSnappedBoundingBox.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

Location:
trunk/Source
Files:
27 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r128005 r128006  
     12012-09-09  Emil A Eklund  <eae@chromium.org>
     2
     3        Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
     4        https://bugs.webkit.org/show_bug.cgi?id=81413
     5
     6        Reviewed by David Hyatt.
     7
     8        Rename Node::getRect and getPixelSnappedRect to boundingBox and
     9        pixelSnappedBoundingBox respectively.
     10
     11        Remove overridden getRect method from ContainerNode as it calculates the
     12        same rect as the Node implementation but in a more complicated and
     13        error-prone way. Also remove the getUpperLeftCorner/getLowerRightCorner
     14        support functions as they are no longer needed.
     15
     16        No new tests, no change in functionality.
     17
     18        * accessibility/AccessibilitySlider.cpp:
     19        (WebCore::AccessibilitySliderThumb::elementRect):
     20        Update to call boundingBox.
     21
     22        * dom/ContainerNode.cpp:
     23        * dom/ContainerNode.h:
     24        Remove overridden getRect method and the getUpperLeftCorner/
     25        getLowerRightCorner support methods .
     26
     27        * dom/Element.cpp:
     28        (WebCore::Element::scrollIntoView):
     29        (WebCore::Element::scrollIntoViewIfNeeded):
     30        (WebCore::Element::updateFocusAppearance):
     31        Update to call boundingBox.
     32       
     33        * dom/Node.h:
     34        * dom/Node.cpp:
     35        (WebCore::Node::boundingBox):
     36        Rename getRect to boundingBox.
     37
     38        (WebCore::Node::pixelSnappedBoundingBox):
     39        Rename getPixelSnappedRect to pixelSnappedBoundingBox.
     40       
     41        * html/ColorInputType.cpp:
     42        (WebCore::ColorInputType::elementRectRelativeToRootView):
     43        * html/ValidationMessage.cpp:
     44        (WebCore::ValidationMessage::buildBubbleTree):
     45        * html/shadow/CalendarPickerElement.cpp:
     46        (WebCore::CalendarPickerElement::openPopup):
     47        * html/shadow/TextControlInnerElements.cpp:
     48        (WebCore::InputFieldSpeechButtonElement::startSpeechInput):
     49        * page/FrameView.cpp:
     50        (WebCore::FrameView::scrollElementToRect):
     51        (WebCore::FrameView::scrollToAnchor):
     52        * page/SpatialNavigation.cpp:
     53        (WebCore::nodeRectInAbsoluteCoordinates):
     54        Update to call boundingBox/pixelSnappedBoundingBox.
     55
    1562012-09-09  Christopher Cameron  <ccameron@chromium.org>
    257

  • trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp

    r123428 r128006  
    178178    if (!sliderRenderer || !sliderRenderer->isSlider())
    179179        return LayoutRect();
    180     return sliderThumbElementOf(sliderRenderer->node())->getRect();
     180    return sliderThumbElementOf(sliderRenderer->node())->boundingBox();
    181181}
    182182

  • trunk/Source/WebCore/dom/ContainerNode.cpp

    r127534 r128006  
    721721}
    722722
    723 bool ContainerNode::getUpperLeftCorner(FloatPoint& point) const
    724 {
    725     if (!renderer())
    726         return false;
    727     // What is this code really trying to do?
    728     RenderObject *o = renderer();
    729     RenderObject *p = o;
    730 
    731     if (!o->isInline() || o->isReplaced()) {
    732         point = o->localToAbsolute(FloatPoint(), false, true);
    733         return true;
    734     }
    735 
    736     // find the next text/image child, to get a position
    737     while (o) {
    738         p = o;
    739         if (o->firstChild())
    740             o = o->firstChild();
    741         else if (o->nextSibling())
    742             o = o->nextSibling();
    743         else {
    744             RenderObject *next = 0;
    745             while (!next && o->parent()) {
    746                 o = o->parent();
    747                 next = o->nextSibling();
    748             }
    749             o = next;
    750 
    751             if (!o)
    752                 break;
    753         }
    754         ASSERT(o);
    755 
    756         if (!o->isInline() || o->isReplaced()) {
    757             point = o->localToAbsolute(FloatPoint(), false, true);
    758             return true;
    759         }
    760 
    761         if (p->node() && p->node() == this && o->isText() && !o->isBR() && !toRenderText(o)->firstTextBox()) {
    762                 // do nothing - skip unrendered whitespace that is a child or next sibling of the anchor
    763         } else if ((o->isText() && !o->isBR()) || o->isReplaced()) {
    764             point = FloatPoint();
    765             if (o->isText() && toRenderText(o)->firstTextBox()) {
    766                 point.move(toRenderText(o)->linesBoundingBox().x(),
    767                            toRenderText(o)->firstTextBox()->root()->lineTop());
    768             } else if (o->isBox()) {
    769                 RenderBox* box = toRenderBox(o);
    770                 point.moveBy(box->location());
    771             }
    772             point = o->container()->localToAbsolute(point, false, true);
    773             return true;
    774         }
    775     }
    776    
    777     // If the target doesn't have any children or siblings that could be used to calculate the scroll position, we must be
    778     // at the end of the document.  Scroll to the bottom. FIXME: who said anything about scrolling?
    779     if (!o && document()->view()) {
    780         point = FloatPoint(0, document()->view()->contentsHeight());
    781         return true;
    782     }
    783     return false;
    784 }
    785 
    786 bool ContainerNode::getLowerRightCorner(FloatPoint& point) const
    787 {
    788     if (!renderer())
    789         return false;
    790 
    791     RenderObject* o = renderer();
    792     if (!o->isInline() || o->isReplaced()) {
    793         RenderBox* box = toRenderBox(o);
    794         point = o->localToAbsolute(LayoutPoint(box->size()), false, true);
    795         return true;
    796     }
    797 
    798     // find the last text/image child, to get a position
    799     while (o) {
    800         if (o->lastChild())
    801             o = o->lastChild();
    802         else if (o->previousSibling())
    803             o = o->previousSibling();
    804         else {
    805             RenderObject* prev = 0;
    806             while (!prev) {
    807                 o = o->parent();
    808                 if (!o)
    809                     return false;
    810                 prev = o->previousSibling();
    811             }
    812             o = prev;
    813         }
    814         ASSERT(o);
    815         if (o->isText() || o->isReplaced()) {
    816             point = FloatPoint();
    817             if (o->isText()) {
    818                 RenderText* text = toRenderText(o);
    819                 IntRect linesBox = text->linesBoundingBox();
    820                 if (!linesBox.maxX() && !linesBox.maxY())
    821                     continue;
    822                 point.moveBy(linesBox.maxXMaxYCorner());
    823             } else {
    824                 RenderBox* box = toRenderBox(o);
    825                 point.moveBy(box->frameRect().maxXMaxYCorner());
    826             }
    827             point = o->container()->localToAbsolute(point, false, true);
    828             return true;
    829         }
    830     }
    831     return true;
    832 }
    833 
    834 LayoutRect ContainerNode::getRect() const
    835 {
    836     FloatPoint  upperLeft, lowerRight;
    837     bool foundUpperLeft = getUpperLeftCorner(upperLeft);
    838     bool foundLowerRight = getLowerRightCorner(lowerRight);
    839    
    840     // If we've found one corner, but not the other,
    841     // then we should just return a point at the corner that we did find.
    842     if (foundUpperLeft != foundLowerRight) {
    843         if (foundUpperLeft)
    844             lowerRight = upperLeft;
    845         else
    846             upperLeft = lowerRight;
    847     }
    848 
    849     return enclosingLayoutRect(FloatRect(upperLeft, lowerRight.expandedTo(upperLeft) - upperLeft));
    850 }
    851 
    852723void ContainerNode::setFocus(bool received)
    853724{

  • trunk/Source/WebCore/dom/ContainerNode.h

    r127593 r128006  
    7676    virtual void attach() OVERRIDE;
    7777    virtual void detach() OVERRIDE;
    78     virtual LayoutRect getRect() const OVERRIDE;
    7978    virtual void setFocus(bool = true) OVERRIDE;
    8079    virtual void setActive(bool active = true, bool pause = false) OVERRIDE;
    … …  
    132131
    133132    static void dispatchPostAttachCallbacks();
    134 
    135     bool getUpperLeftCorner(FloatPoint&) const;
    136     bool getLowerRightCorner(FloatPoint&) const;
    137133
    138134    Node* m_firstChild;

  • trunk/Source/WebCore/dom/Element.cpp

    r127706 r128006  
    284284        return;
    285285
    286     LayoutRect bounds = getRect();
     286    LayoutRect bounds = boundingBox();
    287287    // Align to the top / bottom and to the closest edge.
    288288    if (alignToTop)
    … …  
    299299        return;
    300300
    301     LayoutRect bounds = getRect();
     301    LayoutRect bounds = boundingBox();
    302302    if (centerIfNeeded)
    303303        renderer()->scrollRectToVisible(bounds, ScrollAlignment::alignCenterIfNeeded, ScrollAlignment::alignCenterIfNeeded);
    … …  
    16401640        }
    16411641    } else if (renderer() && !renderer()->isWidget())
    1642         renderer()->scrollRectToVisible(getRect());
     1642        renderer()->scrollRectToVisible(boundingBox());
    16431643}
    16441644

  • trunk/Source/WebCore/dom/Node.cpp

    r127869 r128006  
    797797}
    798798
    799 LayoutRect Node::getRect() const
     799LayoutRect Node::boundingBox() const
    800800{
    801801    if (renderer())

  • trunk/Source/WebCore/dom/Node.h

    r127228 r128006  
    402402
    403403    virtual bool shouldUseInputMethod();
    404     virtual LayoutRect getRect() const;
    405     IntRect getPixelSnappedRect() const { return pixelSnappedIntRect(getRect()); }
     404    virtual LayoutRect boundingBox() const;
     405    IntRect pixelSnappedBoundingBox() const { return pixelSnappedIntRect(boundingBox()); }
    406406    LayoutRect renderRect(bool* isReplaced);
    407407    IntRect pixelSnappedRenderRect(bool* isReplaced) { return pixelSnappedIntRect(renderRect(isReplaced)); }

  • trunk/Source/WebCore/html/ColorInputType.cpp

    r124299 r128006  
    209209IntRect ColorInputType::elementRectRelativeToRootView() const
    210210{
    211     return element()->document()->view()->contentsToRootView(element()->getPixelSnappedRect());
     211    return element()->document()->view()->contentsToRootView(element()->pixelSnappedBoundingBox());
    212212}
    213213

  • trunk/Source/WebCore/html/ValidationMessage.cpp

    r123713 r128006  
    147147    ASSERT(!ec);
    148148    host->document()->updateLayout();
    149     adjustBubblePosition(host->getRect(), m_bubble.get());
     149    adjustBubblePosition(host->boundingBox(), m_bubble.get());
    150150
    151151    RefPtr<HTMLDivElement> clipper = HTMLDivElement::create(doc);

  • trunk/Source/WebCore/html/shadow/CalendarPickerElement.cpp

    r127558 r128006  
    139139    else
    140140        parameters.step = step.toDouble();
    141     parameters.anchorRectInRootView = document()->view()->contentsToRootView(hostInput()->getPixelSnappedRect());
     141    parameters.anchorRectInRootView = document()->view()->contentsToRootView(hostInput()->pixelSnappedBoundingBox());
    142142    parameters.currentValue = input->value();
    143143    // FIXME: parameters.suggestionValues and suggestionLabels will be used when we support datalist.

  • trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp

    r126359 r128006  
    426426    AtomicString language = input->computeInheritedLanguage();
    427427    String grammar = input->getAttribute(webkitgrammarAttr);
    428     IntRect rect = document()->view()->contentsToRootView(getPixelSnappedRect());
     428    IntRect rect = document()->view()->contentsToRootView(pixelSnappedBoundingBox());
    429429    if (speechInput()->startRecognition(m_listenerId, rect, language, grammar, document()->securityOrigin()))
    430430        setState(Recording);

  • trunk/Source/WebCore/page/FrameView.cpp

    r127783 r128006  
    17441744    m_frame->document()->updateLayoutIgnorePendingStylesheets();
    17451745
    1746     LayoutRect bounds = element->getRect();
     1746    LayoutRect bounds = element->boundingBox();
    17471747    int centeringOffsetX = (rect.width() - bounds.width()) / 2;
    17481748    int centeringOffsetY = (rect.height() - bounds.height()) / 2;
    … …  
    23422342    LayoutRect rect;
    23432343    if (anchorNode != m_frame->document())
    2344         rect = anchorNode->getRect();
     2344        rect = anchorNode->boundingBox();
    23452345
    23462346    // Scroll nested layers and frames to reveal the anchor.

  • trunk/Source/WebCore/page/SpatialNavigation.cpp

    r120832 r128006  
    523523    if (node->isDocumentNode())
    524524        return frameRectInAbsoluteCoordinates(static_cast<Document*>(node)->frame());
    525     LayoutRect rect = rectToAbsoluteCoordinates(node->document()->frame(), node->getRect());
     525    LayoutRect rect = rectToAbsoluteCoordinates(node->document()->frame(), node->boundingBox());
    526526
    527527    // For authors that use border instead of outline in their CSS, we compensate by ignoring the border when calculating

  • trunk/Source/WebCore/page/TouchDisambiguation.cpp

    r127876 r128006  
    5959            continue;
    6060        }
    61         result.unite(pixelSnappedIntRect(node->getRect()));
     61        result.unite(node->pixelSnappedBoundingBox());
    6262        node = node->traverseNextNode(eventNode);
    6363    }

  • trunk/Source/WebKit/chromium/ChangeLog

    r127995 r128006  
     12012-09-09  Emil A Eklund  <eae@chromium.org>
     2
     3        Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
     4        https://bugs.webkit.org/show_bug.cgi?id=81413
     5
     6        Reviewed by David Hyatt.
     7
     8        Update WebViewImpl to call boundingBox/pixelSnappedBoundingBox.
     9
     10        * src/WebViewImpl.cpp:
     11        (WebKit::WebViewImpl::computeBlockBounds):
     12        (WebKit::WebViewImpl::applyAutofillSuggestions):
     13        (WebKit::WebViewImpl::refreshAutofillPopup):
     14
    1152012-09-09  James Robinson  <jamesr@chromium.org>
    216
    … …  
    1692516939        (WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
    1692616940        (WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
    16927         (WebKit::WebAccessibilityObject::boundingBoxRect):
     16941        (WebKit::WebAccessibilityObject::boundingBox):
    1692816942        (WebKit::WebAccessibilityObject::estimatedLoadingProgress):
    1692916943        (WebKit::WebAccessibilityObject::helpText):

  • trunk/Source/WebKit/chromium/src/LinkHighlight.cpp

    r127952 r128006  
    150150
    151151    bool pathHasChanged = false;
    152     FloatRect boundingRect = m_node->getPixelSnappedRect();
     152    FloatRect boundingRect = m_node->pixelSnappedBoundingBox();
    153153
    154154    // FIXME: If we ever use a more sophisticated highlight path, we'll need

  • trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

    r127952 r128006  
    10171017    // Return the bounding box in the window coordinate system.
    10181018    if (node) {
    1019         IntRect rect = node->Node::getPixelSnappedRect();
     1019        IntRect rect = node->Node::pixelSnappedBoundingBox();
    10201020        Frame* frame = node->document()->frame();
    10211021        return frame->view()->contentsToWindow(rect);
    … …  
    33083308    } else {
    33093309        m_autofillPopupShowing = true;
    3310         m_autofillPopup->showInRect(focusedNode->getPixelSnappedRect(), focusedNode->ownerDocument()->view(), 0);
     3310        m_autofillPopup->showInRect(focusedNode->pixelSnappedBoundingBox(), focusedNode->ownerDocument()->view(), 0);
    33113311    }
    33123312}
    … …  
    36163616    }
    36173617
    3618     WebRect newWidgetRect = m_autofillPopup->refresh(focusedWebCoreNode()->getPixelSnappedRect());
     3618    WebRect newWidgetRect = m_autofillPopup->refresh(focusedWebCoreNode()->pixelSnappedBoundingBox());
    36193619    // Let's resize the backing window if necessary.
    36203620    WebPopupMenuImpl* popupMenu = static_cast<WebPopupMenuImpl*>(m_autofillPopup->client());

  • trunk/Source/WebKit/efl/ChangeLog

    r127958 r128006  
     12012-09-09  Emil A Eklund  <eae@chromium.org>
     2
     3        Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
     4        https://bugs.webkit.org/show_bug.cgi?id=81413
     5
     6        Reviewed by David Hyatt.
     7
     8        Update ewk_frame to call pixelSnappedBoundingBox.
     9
     10        * ewk/ewk_frame.cpp:
     11        (ewk_frame_focused_element_geometry_get):
     12
    1132012-09-07  Benjamin Poulain  <bpoulain@apple.com>
    214

  • trunk/Source/WebKit/efl/ewk/ewk_frame.cpp

    r127876 r128006  
    899899    if (!focusedNode)
    900900        return false;
    901     WebCore::IntRect nodeRect = focusedNode->getPixelSnappedRect();
     901    WebCore::IntRect nodeRect = focusedNode->pixelSnappedBoundingBox();
    902902    if (x)
    903903        *x = nodeRect.x();

  • trunk/Source/WebKit/gtk/ChangeLog

    r127889 r128006  
     12012-09-09  Emil A Eklund  <eae@chromium.org>
     2
     3        Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
     4        https://bugs.webkit.org/show_bug.cgi?id=81413
     5
     6        Reviewed by David Hyatt.
     7
     8        Update ChromeClientGtk and webkitwebview to call pixelSnappedBoundingBox.
     9
     10        * WebCoreSupport/ChromeClientGtk.cpp:
     11        (WebKit::ChromeClient::mouseDidMoveOverElement):
     12        * webkit/webkitwebview.cpp:
     13        (getLocationForKeyboardGeneratedContextMenu):
     14        (webkit_web_view_query_tooltip):
     15
    1162012-09-07  Martin Robinson  <mrobinson@igalia.com>
    217

  • trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

    r127757 r128006  
    787787        Frame* frame = node->document()->frame();
    788788        FrameView* view = frame ? frame->view() : 0;
    789         m_webView->priv->tooltipArea = view ? view->contentsToWindow(node->getPixelSnappedRect()) : IntRect();
     789        m_webView->priv->tooltipArea = view ? view->contentsToWindow(node->pixelSnappedBoundingBox()) : IntRect();
    790790    } else
    791791        m_webView->priv->tooltipArea = IntRect();

  • trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp

    r127070 r128006  
    428428         || (selection->selection().isCaret() && !selection->selection().isContentEditable())) {
    429429        if (Node* focusedNode = getFocusedNode(frame))
    430             return focusedNode->getPixelSnappedRect().location();
     430            return focusedNode->pixelSnappedBoundingBox().location();
    431431
    432432        // There was no selection and no focused node, so just put the context
    … …  
    16091609                if (!title.isEmpty()) {
    16101610                    if (FrameView* view = coreFrame->view()) {
    1611                         GdkRectangle area = view->contentsToWindow(node->getPixelSnappedRect());
     1611                        GdkRectangle area = view->contentsToWindow(node->pixelSnappedBoundingBox());
    16121612                        gtk_tooltip_set_tip_area(tooltip, &area);
    16131613                    }

  • trunk/Source/WebKit/qt/Api/qwebelement.cpp

    r127238 r128006  
    547547    if (!m_element)
    548548        return QRect();
    549     return m_element->getPixelSnappedRect();
     549    return m_element->pixelSnappedBoundingBox();
    550550}
    551551
    … …  
    14551455    view->updateLayoutAndStyleIfNeededRecursive();
    14561456
    1457     IntRect rect = e->getPixelSnappedRect();
     1457    IntRect rect = e->pixelSnappedBoundingBox();
    14581458
    14591459    if (rect.size().isEmpty())

  • trunk/Source/WebKit/qt/Api/qwebpage.cpp

    r127876 r128006  
    15781578            continue;
    15791579
    1580         IntRect currentElementBoundingRect = currentElement->getPixelSnappedRect();
     1580        IntRect currentElementBoundingRect = currentElement->pixelSnappedBoundingBox();
    15811581        currentElementBoundingRect.intersect(touchRect);
    15821582

  • trunk/Source/WebKit/qt/ChangeLog

    r127876 r128006  
     12012-09-09  Emil A Eklund  <eae@chromium.org>
     2
     3        Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
     4        https://bugs.webkit.org/show_bug.cgi?id=81413
     5
     6        Reviewed by David Hyatt.
     7
     8        Update qwebelement and qwebpage to call pixelSnappedBoundingBox.
     9
     10        * Api/qwebelement.cpp:
     11        (QWebElement::geometry):
     12        (QWebElement::render):
     13        * Api/qwebpage.cpp:
     14        (QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
     15
    1162012-09-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
    217

  • trunk/Source/WebKit2/ChangeLog

    r128003 r128006  
     12012-09-09  Emil A Eklund  <eae@chromium.org>
     2
     3        Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
     4        https://bugs.webkit.org/show_bug.cgi?id=81413
     5
     6        Reviewed by David Hyatt.
     7
     8        Update WebPage to call pixelSnappedBoundingBox.
     9
     10        * WebProcess/WebPage/WebPage.cpp:
     11        (WebKit::WebPage::editorState):
     12
    1132012-09-08  Sam Weinig  <sam@webkit.org>
    214

  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

    r127956 r128006  
    516516
    517517    if (selectionRoot)
    518         result.editorRect = frame->view()->contentsToWindow(selectionRoot->getPixelSnappedRect());
     518        result.editorRect = frame->view()->contentsToWindow(selectionRoot->pixelSnappedBoundingBox());
    519519
    520520    RefPtr<Range> range;
Note: See TracChangeset for help on using the changeset viewer.