Changeset 128657 in webkit

Timestamp:

Sep 14, 2012 2:57:26 PM (12 years ago)

Author:

ap@apple.com

Message:

Minimize collisions when hashing pairs
​https://bugs.webkit.org/show_bug.cgi?id=96022

Build fix (with newer clang?)

• wtf/HashFunctions.h: (WTF::pairIntHash): Be explicit about casting from 64 bit to 32 bit.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/HashFunctions.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2012-09-14  Alexey Proskuryakov  <ap@apple.com>
+
+        Minimize collisions when hashing pairs
+        https://bugs.webkit.org/show_bug.cgi?id=96022
+
+        Build fix (with newer clang?)
+
+        * wtf/HashFunctions.h: (WTF::pairIntHash): Be explicit about casting from
+        64 bit to 32 bit.
+
 2012-09-14  Dana Jansens  <danakj@chromium.org>
 

trunk/Source/WTF/wtf/HashFunctions.h

@@ -95 +95 @@
 
         uint64_t product = longRandom * (shortRandom1 * key1 + shortRandom2 * key2);
-        unsigned highBits = product >> (sizeof(uint64_t) - sizeof(unsigned));
+        unsigned highBits = static_cast<unsigned>(product >> (sizeof(uint64_t) - sizeof(unsigned)));
         return highBits;
     }