Changeset 132545 in webkit

Timestamp:

Oct 25, 2012 5:04:53 PM (11 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/12544626> [cg] RenderBlock::selectionGaps() is extremely slow when there are many floats
​https://bugs.webkit.org/show_bug.cgi?id=100413

Reviewed by Anders Carlsson.

RenderBlock::selectionGaps() calls GraphicsContext::clipOut(const IntRect&) for each float.
Sped up the Core Graphics implementation of this function considerably by removing an
unnecessary call to CGContextGetClipBoundingBox.

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::clipOut): Changed to use CGRectInfinite rather than the bounding
box of the current clip.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cg/GraphicsContextCG.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-25  Dan Bernstein  <mitz@apple.com>
+
+        <rdar://problem/12544626> [cg] RenderBlock::selectionGaps() is extremely slow when there are many floats
+        https://bugs.webkit.org/show_bug.cgi?id=100413
+
+        Reviewed by Anders Carlsson.
+
+        RenderBlock::selectionGaps() calls GraphicsContext::clipOut(const IntRect&) for each float.
+        Sped up the Core Graphics implementation of this function considerably by removing an
+        unnecessary call to CGContextGetClipBoundingBox.
+
+        * platform/graphics/cg/GraphicsContextCG.cpp:
+        (WebCore::GraphicsContext::clipOut): Changed to use CGRectInfinite rather than the bounding
+        box of the current clip.
+
 2012-10-25  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp

@@ -1058 +1058 @@
         return;
 
-    CGRect rects[2] = { CGContextGetClipBoundingBox(platformContext()), rect };
+    CGRect rects[2] = { CGRectInfinite, rect };
     CGContextBeginPath(platformContext());
     CGContextAddRects(platformContext(), rects, 2);