Changeset 135879 in webkit


Ignore:
Timestamp:
Nov 27, 2012, 10:36:27 AM (13 years ago)
Author:
ap@apple.com
Message:

[WK2] WebPageProxy::relatedPages() cannot assume that this page is known to process
https://bugs.webkit.org/show_bug.cgi?id=103433
<rdar://problem/12543513>

Reviewed by Jessie Berlin.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::relatedPages): Removed an incorrect assertion, and modified code to not rely on its condition being true.
Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r135864 r135879  
     12012-11-27  Alexey Proskuryakov  <ap@apple.com>
     2
     3        [WK2] WebPageProxy::relatedPages() cannot assume that this page is known to process
     4        https://bugs.webkit.org/show_bug.cgi?id=103433
     5        <rdar://problem/12543513>
     6
     7        Reviewed by Jessie Berlin.
     8
     9        * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::relatedPages): Removed an incorrect
     10        assertion, and modified code to not rely on its condition being true.
     11
    1122012-11-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
    213
  • trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

    r135844 r135879  
    297297PassRefPtr<ImmutableArray> WebPageProxy::relatedPages() const
    298298{
     299    // pages() returns a list of pages in WebProcess, so this page may or may not be among them - a client can use a reference to WebPageProxy after the page has closed.
    299300    Vector<WebPageProxy*> pages = m_process->pages();
    300     ASSERT(pages.contains(this));
    301301
    302302    Vector<RefPtr<APIObject> > result;
    303     result.reserveCapacity(pages.size() - 1);
     303    result.reserveCapacity(pages.size());
    304304    for (size_t i = 0; i < pages.size(); ++i) {
    305305        if (pages[i] != this)
Note: See TracChangeset for help on using the changeset viewer.