Changeset 135879 in webkit

Timestamp:

Nov 27, 2012, 10:36:27 AM (13 years ago)

Author:

ap@apple.com

Message:

[WK2] WebPageProxy::relatedPages() cannot assume that this page is known to process
​https://bugs.webkit.org/show_bug.cgi?id=103433
<rdar://problem/12543513>

Reviewed by Jessie Berlin.

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::relatedPages): Removed an incorrect assertion, and modified code to not rely on its condition being true.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-11-27  Alexey Proskuryakov  <ap@apple.com>
+
+        [WK2] WebPageProxy::relatedPages() cannot assume that this page is known to process
+        https://bugs.webkit.org/show_bug.cgi?id=103433
+        <rdar://problem/12543513>
+
+        Reviewed by Jessie Berlin.
+
+        * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::relatedPages): Removed an incorrect
+        assertion, and modified code to not rely on its condition being true.
+
 2012-11-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -297 +297 @@
 PassRefPtr<ImmutableArray> WebPageProxy::relatedPages() const
 {
+    // pages() returns a list of pages in WebProcess, so this page may or may not be among them - a client can use a reference to WebPageProxy after the page has closed.
     Vector<WebPageProxy*> pages = m_process->pages();
-    ASSERT(pages.contains(this));
 
     Vector<RefPtr<APIObject> > result;
-    result.reserveCapacity(pages.size() - 1);
+    result.reserveCapacity(pages.size());
     for (size_t i = 0; i < pages.size(); ++i) {
         if (pages[i] != this)