Changeset 137631 in webkit

Timestamp:

Dec 13, 2012 11:46:13 AM (11 years ago)

Author:

ap@apple.com

Message:

ResourceLoader::didReceiveAuthenticationChallenge uses a wrong client
​https://bugs.webkit.org/show_bug.cgi?id=104935
<rdar://problem/12870361>

Reviewed by Anders Carlsson.

• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): The handle is null when NetworkProcess is used. In any case, it should be correct to use the client carried within AuthenticationChallenge.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/ResourceLoader.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-12-13  Alexey Proskuryakov  <ap@apple.com>
+
+        ResourceLoader::didReceiveAuthenticationChallenge uses a wrong client
+        https://bugs.webkit.org/show_bug.cgi?id=104935
+        <rdar://problem/12870361>
+
+        Reviewed by Anders Carlsson.
+
+        * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
+        The handle is null when NetworkProcess is used. In any case, it should be correct
+        to use the client carried within AuthenticationChallenge.
+
 2012-12-13  Stephen White  <senorblanco@chromium.org>
 

trunk/Source/WebCore/loader/ResourceLoader.cpp

@@ -500 +500 @@
     // If we can't continue with credentials, we need to cancel the load altogether.
 #if PLATFORM(MAC) || USE(CFNETWORK) || USE(CURL) || PLATFORM(GTK) || PLATFORM(EFL)
-    handle()->receivedRequestToContinueWithoutCredential(challenge);
-    ASSERT(!handle()->hasAuthenticationChallenge());
+    challenge.authenticationClient()->receivedRequestToContinueWithoutCredential(challenge);
+    ASSERT(!handle() || !handle()->hasAuthenticationChallenge());
 #else
     didFail(blockedError());