Changeset 138851 in webkit


Ignore:
Timestamp:
Jan 4, 2013, 1:39:39 PM (12 years ago)
Author:
mitz@apple.com
Message:

[mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
​https://bugs.webkit.org/show_bug.cgi?id=106121

Reviewed by Adele Peterson.

Source/WebCore:

Test: TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm.

  • bindings/objc/DOM.mm:

(-[DOMHTMLTableCellElement _cellAbove]): Added. Calls HTMLTableCellElement::cellAbove().

  • bindings/objc/DOMPrivate.h: Added declaration of the above.

Tools:

Added test for -[DOMTHMLTableCellElement _cellAbove].

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.

(-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::expectCellAboveCell):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r138850 r138851  
     12013-01-04  Dan Bernstein  <mitz@apple.com>
     2
     3        [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
     4        https://bugs.webkit.org/show_bug.cgi?id=106121
     5
     6        Reviewed by Adele Peterson.
     7
     8        Test: TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm.
     9
     10        * bindings/objc/DOM.mm:
     11        (-[DOMHTMLTableCellElement _cellAbove]): Added. Calls HTMLTableCellElement::cellAbove().
     12        * bindings/objc/DOMPrivate.h: Added declaration of the above.
     13
    1142013-01-04  Abhishek Arya  <inferno@chromium.org>
    215

  • trunk/Source/WebCore/bindings/objc/DOM.mm

    r138747 r138851  
    3232#import "DOMElementInternal.h"
    3333#import "DOMHTMLCanvasElement.h"
     34#import "DOMHTMLTableCellElementInternal.h"
    3435#import "DOMNodeInternal.h"
    3536#import "DOMPrivate.h"
    … …  
    4041#import "HTMLNames.h"
    4142#import "HTMLParserIdioms.h"
     43#import "HTMLTableCellElement.h"
    4244#import "Image.h"
    4345#import "JSNode.h"
    … …  
    540542
    541543
     544@implementation DOMHTMLTableCellElement (WebPrivate)
     545
     546- (DOMHTMLTableCellElement *)_cellAbove
     547{
     548    return kit(core(self)->cellAbove());
     549}
     550
     551@end
     552
    542553//------------------------------------------------------------------------------------------
    543554// DOMNodeFilter

  • trunk/Source/WebCore/bindings/objc/DOMPrivate.h

    r138747 r138851  
    7272@end
    7373
     74@interface DOMHTMLTableCellElement (WebPrivate)
     75- (DOMHTMLTableCellElement *)_cellAbove;
     76@end
     77
    7478// All the methods in this category are used by Safari forms autofill and should not be used for any other purpose.
    7579// Each one should eventually be replaced by public DOM API, and when that happens Safari will switch to implementations

  • trunk/Tools/ChangeLog

    r138826 r138851  
     12013-01-04  Dan Bernstein  <mitz@apple.com>
     2
     3        [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
     4        https://bugs.webkit.org/show_bug.cgi?id=106121
     5
     6        Reviewed by Adele Peterson.
     7
     8        Added test for -[DOMTHMLTableCellElement _cellAbove].
     9
     10        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
     11        * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
     12        (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
     13        (TestWebKitAPI):
     14        (TestWebKitAPI::expectCellAboveCell):
     15        (TestWebKitAPI::TEST):
     16        * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
     17
    1182013-01-04  Eric Seidel  <eric@webkit.org>
    219

  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r138747 r138851  
    5757                37DC678D140D7C5000ABCCDB /* DOMRangeOfString.mm in Sources */ = {isa = PBXBuildFile; fileRef = 37DC678B140D7C5000ABCCDB /* DOMRangeOfString.mm */; };
    5858                37DC6791140D7D7600ABCCDB /* DOMRangeOfString.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 37DC678F140D7D3A00ABCCDB /* DOMRangeOfString.html */; };
     59                37E1064C1697681800B78BD0 /* DOMHTMLTableCellElementCellAbove.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 37E1064B169767F700B78BD0 /* DOMHTMLTableCellElementCellAbove.html */; };
     60                37E1064D16976C8500B78BD0 /* DOMHTMLTableCellCellAbove.mm in Sources */ = {isa = PBXBuildFile; fileRef = 37E1064A1697676400B78BD0 /* DOMHTMLTableCellCellAbove.mm */; };
    5961                440A1D3914A0103A008A66F2 /* KURL.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 440A1D3814A0103A008A66F2 /* KURL.cpp */; };
    6062                4BB4160216815B2600824238 /* JSWrapperForNodeInWebFrame.mm in Sources */ = {isa = PBXBuildFile; fileRef = 4BB4160116815B2600824238 /* JSWrapperForNodeInWebFrame.mm */; };
    … …  
    226228                                26DF5A6315A2A27E003689C2 /* CancelLoadFromResourceLoadDelegate.html in Copy Resources */,
    227229                                5142B2731517C8C800C32B19 /* ContextMenuCanCopyURL.html in Copy Resources */,
     230                                37E1064C1697681800B78BD0 /* DOMHTMLTableCellElementCellAbove.html in Copy Resources */,
    228231                                9B4F8FA7159D52DD002D9F94 /* HTMLCollectionNamedItem.html in Copy Resources */,
    229232                                9B26FCCA159D16DE00CC3765 /* HTMLFormCollectionNamedItem.html in Copy Resources */,
    … …  
    307310                37DC678B140D7C5000ABCCDB /* DOMRangeOfString.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DOMRangeOfString.mm; sourceTree = "<group>"; };
    308311                37DC678F140D7D3A00ABCCDB /* DOMRangeOfString.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = DOMRangeOfString.html; sourceTree = "<group>"; };
     312                37E1064A1697676400B78BD0 /* DOMHTMLTableCellCellAbove.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DOMHTMLTableCellCellAbove.mm; sourceTree = "<group>"; };
     313                37E1064B169767F700B78BD0 /* DOMHTMLTableCellElementCellAbove.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = DOMHTMLTableCellElementCellAbove.html; sourceTree = "<group>"; };
    309314                440A1D3814A0103A008A66F2 /* KURL.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = KURL.cpp; sourceTree = "<group>"; };
    310315                44A622C114A0E2B60048515B /* WTFStringUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WTFStringUtilities.h; sourceTree = "<group>"; };
    … …  
    760765                                26DF5A5D15A29BAA003689C2 /* CancelLoadFromResourceLoadDelegate.mm */,
    761766                                5142B2701517C88B00C32B19 /* ContextMenuCanCopyURL.mm */,
     767                                37E1064A1697676400B78BD0 /* DOMHTMLTableCellCellAbove.mm */,
    762768                                3751AF7A169518F800764319 /* DOMNodeFromJSObject.mm */,
    763769                                37DC678B140D7C5000ABCCDB /* DOMRangeOfString.mm */,
    … …  
    795801                                26DF5A6115A2A22B003689C2 /* CancelLoadFromResourceLoadDelegate.html */,
    796802                                5142B2721517C89100C32B19 /* ContextMenuCanCopyURL.html */,
     803                                37E1064B169767F700B78BD0 /* DOMHTMLTableCellElementCellAbove.html */,
    797804                                37DC678F140D7D3A00ABCCDB /* DOMRangeOfString.html */,
    798805                                9B4F8FA6159D52CA002D9F94 /* HTMLCollectionNamedItem.html */,
    … …  
    10471054                                4BB4160416815F9100824238 /* ElementAtPointInWebFrame.mm in Sources */,
    10481055                                3751AF7C169518F800764319 /* DOMNodeFromJSObject.mm in Sources */,
     1056                                37E1064D16976C8500B78BD0 /* DOMHTMLTableCellCellAbove.mm in Sources */,
    10491057                        );
    10501058                        runOnlyForDeploymentPostprocessing = 0;
Note: See TracChangeset for help on using the changeset viewer.