Changeset 139515 in webkit

Timestamp:

Jan 11, 2013, 4:04:23 PM (12 years ago)

Author:

ap@apple.com

Message:

[WK2] Make it possible to send sync messages from secondary threads
​https://bugs.webkit.org/show_bug.cgi?id=106708

Apply another review comment (overlooked a "ditto").

• Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/CoreIPC/Connection.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-01-11  Alexey Proskuryakov  <ap@apple.com>
+
+        [WK2] Make it possible to send sync messages from secondary threads
+        https://bugs.webkit.org/show_bug.cgi?id=106708
+
+        Apply another review comment (overlooked a "ditto").
+
+        * Platform/CoreIPC/Connection.cpp:
+        (CoreIPC::Connection::sendSyncMessage):
+
 2013-01-11  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp

@@ -406 +406 @@
     }
 
-    if (!isValid()) {
-        didFailToSendSyncMessage();
+    if (!isValid())
         return nullptr;
-    }
 
     // Push the pending sync reply information on our stack.
@@ -436 +434 @@
         m_pendingSyncReplies.removeLast();
     }
-
-    // FIXME: Should we call didFailToSendSyncMessage()? It may be unexpected to get in on a background thread.
 
     return reply.release();