Changeset 143265 in webkit

Timestamp:

Feb 18, 2013, 2:38:46 PM (12 years ago)

Author:

ap@apple.com

Message:

Make HexNumber functions return 8-bit strings
​https://bugs.webkit.org/show_bug.cgi?id=110152

Reviewed by Michael Saboff.

• wtf/HexNumber.h: (Internal): (WTF::Internal::hexDigitsForMode): (WTF::appendByteAsHex): (WTF::placeByteAsHexCompressIfPossible): (WTF::placeByteAsHex): (WTF::appendUnsignedAsHex): (WTF::appendUnsignedAsHexFixedSize): Use LChar everywhere.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/HexNumber.h (modified) (6 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-02-18  Alexey Proskuryakov  <ap@apple.com>
+
+        Make HexNumber functions return 8-bit strings
+        https://bugs.webkit.org/show_bug.cgi?id=110152
+
+        Reviewed by Michael Saboff.
+
+        * wtf/HexNumber.h:
+        (Internal):
+        (WTF::Internal::hexDigitsForMode):
+        (WTF::appendByteAsHex):
+        (WTF::placeByteAsHexCompressIfPossible):
+        (WTF::placeByteAsHex):
+        (WTF::appendUnsignedAsHex):
+        (WTF::appendUnsignedAsHexFixedSize):
+        Use LChar everywhere.
+
 2013-02-18  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WTF/wtf/HexNumber.h

@@ -32 +32 @@
 namespace Internal {
 
-const char lowerHexDigits[17] = "0123456789abcdef";
-const char upperHexDigits[17] = "0123456789ABCDEF";
-inline const char* hexDigitsForMode(HexConversionMode mode)
+const LChar lowerHexDigits[17] = "0123456789abcdef";
+const LChar upperHexDigits[17] = "0123456789ABCDEF";
+inline const LChar* hexDigitsForMode(HexConversionMode mode)
 {
     return mode == Lowercase ? lowerHexDigits : upperHexDigits;
@@ -44 +44 @@
 inline void appendByteAsHex(unsigned char byte, T& destination, HexConversionMode mode = Uppercase)
 {
-    const char* hexDigits = Internal::hexDigitsForMode(mode);
+    const LChar* hexDigits = Internal::hexDigitsForMode(mode);
     destination.append(hexDigits[byte >> 4]);
     destination.append(hexDigits[byte & 0xF]);
@@ -52 +52 @@
 inline void placeByteAsHexCompressIfPossible(unsigned char byte, T& destination, unsigned& index, HexConversionMode mode = Uppercase)
 {
-    const char* hexDigits = Internal::hexDigitsForMode(mode);
+    const LChar* hexDigits = Internal::hexDigitsForMode(mode);
     if (byte >= 0x10)
         destination[index++] = hexDigits[byte >> 4];
@@ -61 +61 @@
 inline void placeByteAsHex(unsigned char byte, T& destination, HexConversionMode mode = Uppercase)
 {
-    const char* hexDigits = Internal::hexDigitsForMode(mode);
+    const LChar* hexDigits = Internal::hexDigitsForMode(mode);
     *destination++ = hexDigits[byte >> 4];
     *destination++ = hexDigits[byte & 0xF];
@@ -69 +69 @@
 inline void appendUnsignedAsHex(unsigned number, T& destination, HexConversionMode mode = Uppercase)
 {
-    const char* hexDigits = Internal::hexDigitsForMode(mode);
-    Vector<UChar, 8> result;
+    const LChar* hexDigits = Internal::hexDigitsForMode(mode);
+    Vector<LChar, 8> result;
     do {
         result.prepend(hexDigits[number % 16]);
@@ -85 +85 @@
     ASSERT(desiredDigits);
 
-    const char* hexDigits = Internal::hexDigitsForMode(mode);
-    Vector<UChar, 8> result;
+    const LChar* hexDigits = Internal::hexDigitsForMode(mode);
+    Vector<LChar, 8> result;
     do {
         result.prepend(hexDigits[number % 16]);