Changeset 150090 in webkit


Ignore:
Timestamp:
May 14, 2013 3:20:51 PM (11 years ago)
Author:
ap@apple.com
Message:

[Mac] Add tests for secure event input
https://bugs.webkit.org/show_bug.cgi?id=116121

Reviewed by Mark Rowe.

  • editing/secure-input: Added.
  • editing/secure-input/password-input-changed-type-expected.txt: Added.
  • editing/secure-input/password-input-changed-type.html: Added.
  • editing/secure-input/password-input-focusing-expected.txt: Added.
  • editing/secure-input/password-input-focusing-to-different-frame-expected.txt: Added.
  • editing/secure-input/password-input-focusing-to-different-frame.html: Added.
  • editing/secure-input/password-input-focusing.html: Added.
  • editing/secure-input/removed-password-input-expected.txt: Added.
  • editing/secure-input/removed-password-input.html: Added.
  • editing/secure-input/reset-state-on-navigation-expected.txt: Added.
  • editing/secure-input/reset-state-on-navigation.html: Added.
  • editing/secure-input/resources: Added.
  • editing/secure-input/resources/reset-state-on-navigation-target.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
Location:
trunk
Files:
13 added
15 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r150087 r150090  
     12013-05-14  Alexey Proskuryakov  <ap@apple.com>
     2
     3        [Mac] Add tests for secure event input
     4        https://bugs.webkit.org/show_bug.cgi?id=116121
     5
     6        Reviewed by Mark Rowe.
     7
     8        * editing/secure-input: Added.
     9        * editing/secure-input/password-input-changed-type-expected.txt: Added.
     10        * editing/secure-input/password-input-changed-type.html: Added.
     11        * editing/secure-input/password-input-focusing-expected.txt: Added.
     12        * editing/secure-input/password-input-focusing-to-different-frame-expected.txt: Added.
     13        * editing/secure-input/password-input-focusing-to-different-frame.html: Added.
     14        * editing/secure-input/password-input-focusing.html: Added.
     15        * editing/secure-input/removed-password-input-expected.txt: Added.
     16        * editing/secure-input/removed-password-input.html: Added.
     17        * editing/secure-input/reset-state-on-navigation-expected.txt: Added.
     18        * editing/secure-input/reset-state-on-navigation.html: Added.
     19        * editing/secure-input/resources: Added.
     20        * editing/secure-input/resources/reset-state-on-navigation-target.html: Added.
     21        * platform/efl/TestExpectations:
     22        * platform/gtk/TestExpectations:
     23        * platform/mac-wk2/TestExpectations:
     24        * platform/mac/TestExpectations:
     25        * platform/qt/TestExpectations:
     26        * platform/win/TestExpectations:
     27        * platform/wincairo/TestExpectations:
     28
    1292013-05-14  David Hyatt  <hyatt@apple.com>
    230
  • trunk/LayoutTests/platform/efl/TestExpectations

    r150059 r150090  
    608608webkit.org/b/105542 fast/canvas/canvas-blend-image.html [ Skip ]
    609609webkit.org/b/105542 fast/canvas/canvas-blend-solid.html [ Skip ]
     610
     611# No concept of secure text input
     612editing/secure-input [ Failure ]
    610613
    611614#////////////////////////////////////////////////////////////////////////////////////////
  • trunk/LayoutTests/platform/gtk/TestExpectations

    r150083 r150090  
    415415webkit.org/b/115374 editing/shadow [ Skip ]
    416416webkit.org/b/115374 fast/dom/shadow [ Skip ]
     417
     418# No concept of secure text input
     419editing/secure-input [ Failure ]
    417420
    418421#////////////////////////////////////////////////////////////////////////////////////////
  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r149333 r150090  
    315315sputnik/Unicode/Unicode_218/S7.6_A5.2_T1.html
    316316
     317# Unclear yet why this test fails.
     318editing/secure-input/password-input-focusing-to-different-frame.html [ Failure ]
     319
    317320### END OF (3) Unclassified failures
    318321########################################
     
    332335plugins/snapshotting [ Skip ]
    333336
     337# This test fails with WebKit1 only.
     338editing/secure-input/reset-state-on-navigation.html [ Pass ]
     339
    334340### END OF (5) Features that are not supported in WebKit1, so skipped in mac/TestExpectations then re-enabled here
    335341########################################
  • trunk/LayoutTests/platform/mac/TestExpectations

    r150083 r150090  
    15361536webkit.org/b/115292 fast/writing-mode/vertical-baseline-alignment.html
    15371537webkit.org/b/115292 fast/writing-mode/vertical-font-fallback.html
     1538
     1539# Fails with WebKit1 only.
     1540editing/secure-input/reset-state-on-navigation.html [ Failure ]
     1541
     1542# Needs rebaseline after bug https://bugs.webkit.org/show_bug.cgi?id=52185
     1543webkit.org/b/52185 fast/table/007.html [ Failure Rebaseline ]
     1544webkit.org/b/52185 fast/table/colspanMinWidth.html [ Failure Rebaseline ]
     1545webkit.org/b/52185 fast/table/colspanMinWidth-vertical.html [ Failure Rebaseline ]
     1546webkit.org/b/52185 fast/table/spanOverlapRepaint.html [ Failure Rebaseline ]
     1547webkit.org/b/52185 tables/mozilla/bugs/bug13169.html [ Failure Rebaseline ]
     1548webkit.org/b/52185 tables/mozilla/bugs/bug133756-1.html [ Failure Rebaseline ]
     1549webkit.org/b/52185 tables/mozilla/bugs/bug133756-2.html [ Failure Rebaseline ]
     1550webkit.org/b/52185 tables/mozilla/bugs/bug17138.html [ Failure Rebaseline ]
     1551webkit.org/b/52185 tables/mozilla/bugs/bug17548.html [ Failure Rebaseline ]
     1552webkit.org/b/52185 tables/mozilla/bugs/bug220536.html [ Failure Rebaseline ]
     1553webkit.org/b/52185 tables/mozilla/bugs/bug6304.html [ Failure Rebaseline ]
     1554webkit.org/b/52185 tables/mozilla/bugs/bug73321.html [ Failure Rebaseline ]
     1555webkit.org/b/52185 tables/mozilla/bugs/bug7714.html [ Failure Rebaseline ]
     1556webkit.org/b/52185 tables/mozilla/bugs/bug86708.html [ ImageOnlyFailure Rebaseline ]
     1557webkit.org/b/52185 tables/mozilla/bugs/bug8858.html [ Failure Rebaseline ]
     1558webkit.org/b/52185 tables/mozilla/core/bloomberg.html [ Failure Rebaseline ]
     1559webkit.org/b/52185 tables/mozilla/core/cell_heights.html [ Failure Rebaseline ]
     1560webkit.org/b/52185 tables/mozilla/other/test6.html [ Failure Rebaseline ]
     1561webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug1010.html [ Failure Rebaseline ]
     1562webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug131020-3.html [ Failure Rebaseline ]
     1563webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug23847.html [ Failure Rebaseline ]
     1564webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug58402-2.html [ Failure Rebaseline ]
     1565webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug65372.html [ Failure Rebaseline ]
     1566webkit.org/b/52185 tables/mozilla_expected_failures/bugs/bug6933.html [ Failure Rebaseline ]
     1567webkit.org/b/52185 accessibility/table-cells.html [ Failure Rebaseline ]
     1568webkit.org/b/52185 accessibility/table-attributes.html [ Failure Rebaseline ]
  • trunk/LayoutTests/platform/qt/TestExpectations

    r150083 r150090  
    496496# X-Content-Type-Options (ENABLE_NOSNIFF) is not enabled.
    497497http/tests/security/contentTypeOptions
     498
     499# No concept of secure text input other than on Mac; support not yet implemented on Mac.
     500editing/secure-input [ Failure ]
    498501
    499502# =========================================================================== #
  • trunk/LayoutTests/platform/win/TestExpectations

    r149906 r150090  
    27432743compositing/filters/sw-shadow-overlaps-hw-layer.html
    27442744compositing/filters/sw-shadow-overlaps-hw-shadow.html
     2745
     2746# No concept of secure text input
     2747editing/secure-input [ Failure ]
  • trunk/LayoutTests/platform/wincairo/TestExpectations

    r149068 r150090  
    29902990# Need support for ResourceHandle::didChangePriority and DRT support
    29912991webkit.org/b/?????? http/tests/loading/promote-img-preload-priority.html [ Failure ]
     2992
     2993# No concept of secure text input
     2994editing/secure-input [ Failure ]
  • trunk/Tools/ChangeLog

    r150089 r150090  
     12013-05-14  Alexey Proskuryakov  <ap@apple.com>
     2
     3        [Mac] Add tests for secure event input
     4        https://bugs.webkit.org/show_bug.cgi?id=116121
     5
     6        Reviewed by Mark Rowe.
     7
     8        * DumpRenderTree/TestRunner.cpp:
     9        (getSecureEventInputIsEnabledCallback):
     10        (TestRunner::staticValues):
     11        Expose an accessor for current secure event input state.
     12
     13        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
     14        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
     15        (WTR::TestRunner::secureEventInputIsEnabled):
     16        * WebKitTestRunner/InjectedBundle/TestRunner.h:
     17        * WebKitTestRunner/TestInvocation.cpp:
     18        (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
     19        Expose an accessor for current secure event input state. This has to be done in
     20        UI process, as this is where it's changed by WebKit.
     21
    1222013-05-14  Alexey Proskuryakov  <ap@apple.com>
    223
  • trunk/Tools/DumpRenderTree/TestRunner.cpp

    r149087 r150090  
    4444#include <wtf/OwnArrayPtr.h>
    4545#include <wtf/RefPtr.h>
     46
     47#if PLATFORM(MAC)
     48#include <Carbon/Carbon.h>
     49#endif
    4650
    4751const unsigned TestRunner::viewWidth = 800;
     
    18351839#endif
    18361840
     1841static JSValueRef getSecureEventInputIsEnabledCallback(JSContextRef context, JSObjectRef thisObject, JSStringRef propertyName, JSValueRef* exception)
     1842{
     1843    return JSValueMakeBoolean(context, IsSecureEventInputEnabled());
     1844}
     1845
    18371846static JSValueRef getTitleTextDirectionCallback(JSContextRef context, JSObjectRef thisObject, JSStringRef propertyName, JSValueRef* exception)
    18381847{
     
    20022011        { "platformName", getPlatformNameCallback, 0, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    20032012#endif
     2013        { "secureEventInputIsEnabled", getSecureEventInputIsEnabledCallback, 0, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    20042014        { "titleTextDirection", getTitleTextDirectionCallback, 0, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    20052015        { 0, 0, 0, 0 }
  • trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl

    r150046 r150090  
    188188    void setAuthenticationUsername(DOMString username);
    189189    void setAuthenticationPassword(DOMString password);
     190
     191    // Secure text input mode (Mac only)
     192    readonly attribute boolean secureEventInputIsEnabled;
    190193};
    191194
  • trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp

    r150046 r150090  
    804804}
    805805
     806bool TestRunner::secureEventInputIsEnabled() const
     807{
     808    WKRetainPtr<WKStringRef> messageName(AdoptWK, WKStringCreateWithUTF8CString("SecureEventInputIsEnabled"));
     809    WKTypeRef returnData = 0;
     810
     811    WKBundlePostSynchronousMessage(InjectedBundle::shared().bundle(), messageName.get(), 0, &returnData);
     812    return WKBooleanGetValue(static_cast<WKBooleanRef>(returnData));
     813}
     814
    806815} // namespace WTR
  • trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h

    r150046 r150090  
    274274    void queueNonLoadingScript(JSStringRef script);
    275275
     276    bool secureEventInputIsEnabled() const;
     277
    276278private:
    277279    static const double waitToDumpWatchdogTimerInterval;
  • trunk/Tools/WebKitTestRunner/TestInvocation.cpp

    r149087 r150090  
    4444
    4545#if PLATFORM(MAC)
     46#include <Carbon/Carbon.h>
    4647#include <WebKit2/WKPagePrivateMac.h>
    4748#endif
     
    664665    }
    665666
     667    if (WKStringIsEqualToUTF8CString(messageName, "SecureEventInputIsEnabled")) {
     668#if PLATFORM(MAC)
     669        WKRetainPtr<WKBooleanRef> result(AdoptWK, WKBooleanCreate(IsSecureEventInputEnabled()));
     670#else
     671        WKRetainPtr<WKBooleanRef> result(AdoptWK, WKBooleanCreate(false);
     672#endif
     673        return result;
     674    }
    666675    ASSERT_NOT_REACHED();
    667676    return 0;
  • trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj

    r149692 r150090  
    8686                BCDA2B9A1191051F00C3BC47 /* JavaScriptCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BCDA2B991191051F00C3BC47 /* JavaScriptCore.framework */; };
    8787                C0CE720B1247C93300BC0EC4 /* TestRunnerMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = C0CE720A1247C93300BC0EC4 /* TestRunnerMac.mm */; };
     88                E1BA671E1742DA6A00C20251 /* Carbon.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = E1BA671D1742DA5A00C20251 /* Carbon.framework */; };
    8889/* End PBXBuildFile section */
    8990
     
    219220                BCDA2B991191051F00C3BC47 /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; path = JavaScriptCore.framework; sourceTree = BUILT_PRODUCTS_DIR; };
    220221                C0CE720A1247C93300BC0EC4 /* TestRunnerMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = TestRunnerMac.mm; path = mac/TestRunnerMac.mm; sourceTree = "<group>"; };
     222                E1BA671D1742DA5A00C20251 /* Carbon.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Carbon.framework; path = System/Library/Frameworks/Carbon.framework; sourceTree = SDKROOT; };
    221223/* End PBXFileReference section */
    222224
     
    229231                                BCDA2B9A1191051F00C3BC47 /* JavaScriptCore.framework in Frameworks */,
    230232                                0F5169CB1445222D00E0A9D7 /* WebKit.framework in Frameworks */,
     233                                E1BA671E1742DA6A00C20251 /* Carbon.framework in Frameworks */,
    231234                                BC7934AC1190658C005EA8E2 /* WebKit2.framework in Frameworks */,
    232235                        );
     
    292295                        isa = PBXGroup;
    293296                        children = (
     297                                E1BA671D1742DA5A00C20251 /* Carbon.framework */,
    294298                                BC7934A411906584005EA8E2 /* Cocoa.framework */,
    295299                                BCDA2B991191051F00C3BC47 /* JavaScriptCore.framework */,
Note: See TracChangeset for help on using the changeset viewer.