Changeset 152579 in webkit

Timestamp:

Jul 11, 2013, 3:33:11 PM (12 years ago)

Author:

mitz@apple.com

Message:

[mac] No API for getting the page visibility state of a WebView
​https://bugs.webkit.org/show_bug.cgi?id=118578

Reviewed by Simon Fraser.

Source/WebCore:

• WebCore.exp.in: Export WebCore::Page::visibilityState().

Source/WebKit/mac:

• WebView/WebView.mm:

(kit): Added. Converts from WebCore::PageVisibilityState to WebPageVisibilityState.
(-[WebView _visibilityState]): Added.

• WebView/WebViewPrivate.h: Declared -_visibilityState.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/WebCore.exp.in (modified) (1 diff)
• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebView/WebView.mm (modified) (2 diffs)
• WebKit/mac/WebView/WebViewPrivate.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-07-11  Dan Bernstein  <mitz@apple.com>
+
+        [mac] No API for getting the page visibility state of a WebView
+        https://bugs.webkit.org/show_bug.cgi?id=118578
+
+        Reviewed by Simon Fraser.
+
+        * WebCore.exp.in: Export WebCore::Page::visibilityState().
+
 2013-07-11  Mario Sanchez Prada  <mario.prada@samsung.com>
 

trunk/Source/WebCore/WebCore.exp.in

@@ -1566 +1566 @@
 __ZNK7WebCore4Page14renderTreeSizeEv
 __ZNK7WebCore4Page15backForwardListEv
+__ZNK7WebCore4Page15visibilityStateEv
 __ZNK7WebCore4Page16hasSeenAnyPluginEv
 __ZNK7WebCore4Page17viewportArgumentsEv

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2013-07-11  Dan Bernstein  <mitz@apple.com>
+
+        [mac] No API for getting the page visibility state of a WebView
+        https://bugs.webkit.org/show_bug.cgi?id=118578
+
+        Reviewed by Simon Fraser.
+
+        * WebView/WebView.mm:
+        (kit): Added. Converts from WebCore::PageVisibilityState to WebPageVisibilityState.
+        (-[WebView _visibilityState]): Added.
+        * WebView/WebViewPrivate.h: Declared -_visibilityState.
+
 2013-07-11  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebView.mm

@@ -431 +431 @@
 }
 
+static WebPageVisibilityState kit(PageVisibilityState visibilityState)
+{
+    switch (visibilityState) {
+    case PageVisibilityStateVisible:
+        return WebPageVisibilityStateVisible;
+    case PageVisibilityStateHidden:
+        return WebPageVisibilityStateHidden;
+    case PageVisibilityStatePrerender:
+        return WebPageVisibilityStatePrerender;
+    case PageVisibilityStateUnloaded:
+        return WebPageVisibilityStateUnloaded;
+    }
+
+    ASSERT_NOT_REACHED();
+    return WebPageVisibilityStateVisible;
+}
+
 @interface WebView (WebFileInternal)
 - (float)_deviceScaleFactor;
@@ -2950 +2967 @@
 
     return kitLayoutMilestones(page->requestedLayoutMilestones());
+}
+
+- (WebPageVisibilityState)_visibilityState
+{
+#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
+    if (_private->page)
+        return kit(_private->page->visibilityState());
+#endif
+    return WebPageVisibilityStateVisible;
 }
 

trunk/Source/WebKit/mac/WebView/WebViewPrivate.h

@@ -585 +585 @@
 - (WebLayoutMilestones)_layoutMilestones;
 
+- (WebPageVisibilityState)_visibilityState;
 - (void)_setVisibilityState:(WebPageVisibilityState)visibilityState isInitialState:(BOOL)isInitialState;