Changeset 153088 in webkit

Timestamp:

Jul 24, 2013, 10:12:15 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Graphical elements inside mphantom should not be visible.
​https://bugs.webkit.org/show_bug.cgi?id=116600.

Patch by Frédéric Wang <​fred.wang@free.fr> on 2013-07-24
Reviewed by Chris Fleizach.

Source/WebCore:

Test: mathml/presentation/phantom.html

• rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::paint): don't paint the fraction bar when the visibility is not "visible"

• rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint): don't paint the radical symbol when the visibility is not "visible"

LayoutTests:

• mathml/presentation/phantom-expected.html: Added.
• mathml/presentation/phantom.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/mathml/presentation/phantom-expected.html (added)
• LayoutTests/mathml/presentation/phantom.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp (modified) (1 diff)
• Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-07-24  Frédéric Wang  <fred.wang@free.fr>
+
+        Graphical elements inside mphantom should not be visible.
+        https://bugs.webkit.org/show_bug.cgi?id=116600.
+
+        Reviewed by Chris Fleizach.
+
+        * mathml/presentation/phantom-expected.html: Added.
+        * mathml/presentation/phantom.html: Added.
+
 2013-07-24  Simon Pena  <simon.pena@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-07-24  Frédéric Wang  <fred.wang@free.fr>
+
+        Graphical elements inside mphantom should not be visible.
+        https://bugs.webkit.org/show_bug.cgi?id=116600.
+
+        Reviewed by Chris Fleizach.
+
+        Test: mathml/presentation/phantom.html
+
+        * rendering/mathml/RenderMathMLFraction.cpp:
+        (WebCore::RenderMathMLFraction::paint): don't paint the fraction bar when the visibility is not "visible"
+        * rendering/mathml/RenderMathMLRoot.cpp:
+        (WebCore::RenderMathMLRoot::paint): don't paint the radical symbol when the visibility is not "visible"
+
 2013-07-24  Brendan Long  <b.long@cablelabs.com>
 

trunk/Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp

@@ -144 +144 @@
 {
     RenderMathMLBlock::paint(info, paintOffset);
-    if (info.context->paintingDisabled() || info.phase != PaintPhaseForeground)
+    if (info.context->paintingDisabled() || info.phase != PaintPhaseForeground || style()->visibility() != VISIBLE)
         return;
     

trunk/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp

@@ -252 +252 @@
     RenderMathMLBlock::paint(info, paintOffset);
     
-    if (info.context->paintingDisabled())
+    if (info.context->paintingDisabled() || style()->visibility() != VISIBLE)
         return;