Changeset 153418 in webkit

Timestamp:

Jul 28, 2013 11:23:55 PM (11 years ago)

Author:

akling@apple.com

Message:

Don't update the text track override CSS every time a media element is created.
<​http://webkit.org/b/119199>
<rdar://problem/14572855>

Reviewed by Darin Adler.

We should only have to update the CSS if the accessibility caption preferences are changed.
This was forcing a full style recalc in every Document any time a media element is instantiated.

• page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/CaptionUserPreferencesMediaAF.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-07-28  Andreas Kling  <akling@apple.com>
+
+        Don't update the text track override CSS every time a media element is created.
+        <http://webkit.org/b/119199>
+        <rdar://problem/14572855>
+
+        Reviewed by Darin Adler.
+
+        We should only have to update the CSS if the accessibility caption preferences are changed.
+        This was forcing a full style recalc in every Document any time a media element is instantiated.
+
+        * page/CaptionUserPreferencesMediaAF.cpp:
+        (WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges):
+
 2013-07-28  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp

@@ -236 +236 @@
         m_listeningForPreferenceChanges = true;
         CFNotificationCenterAddObserver(CFNotificationCenterGetLocalCenter(), this, userCaptionPreferencesChangedNotificationCallback, kMAXCaptionAppearanceSettingsChangedNotification, 0, CFNotificationSuspensionBehaviorCoalesce);
-    }
-    
-    updateCaptionStyleSheetOveride();
+        updateCaptionStyleSheetOveride();
+    }
 }