Changeset 155000 in webkit

Timestamp:

Sep 3, 2013, 2:47:45 PM (12 years ago)

Author:

ap@apple.com

Message:

[Mac] WebKitTestRunner still beeps sometimes
​https://bugs.webkit.org/show_bug.cgi?id=120652

Reviewed by Tim Horton.

In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
UI process (notably, AppKit beeps when handling a key equivalent returns NO).

• WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize): Use the same SPI that we use in DRT and in WebProcess to disable beeping.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/mac/TestControllerMac.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-09-03  Alexey Proskuryakov  <ap@apple.com>
+
+        [Mac] WebKitTestRunner still beeps sometimes
+        https://bugs.webkit.org/show_bug.cgi?id=120652
+
+        Reviewed by Tim Horton.
+
+        In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
+        UI process (notably, AppKit beeps when handling a key equivalent returns NO).
+
+        * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
+        Use the same SPI that we use in DRT and in WebProcess to disable beeping.
+
 2013-09-03  Krzysztof Czech  <k.czech@samsung.com>
 

trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm

@@ -33 +33 @@
 #import <mach-o/dyld.h> 
 
+@interface NSSound (Details)
++ (void)_setAlertType:(NSUInteger)alertType;
+@end
+
 namespace WTR {
 
@@ -43 +47 @@
     poseAsClass("WebKitTestRunnerPasteboard", "NSPasteboard");
     poseAsClass("WebKitTestRunnerEvent", "NSEvent");
+
+    [NSSound _setAlertType:0];
 }