Changeset 155568 in webkit

Timestamp:

Sep 11, 2013, 3:07:12 PM (11 years ago)

Author:

mitz@apple.com

Message:

REGRESSION (r155561): extract-localizable-strings can miss strings
​https://bugs.webkit.org/show_bug.cgi?id=121184

Reviewed by Darin Adler.

• Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing

parenthesis or bracket.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/extract-localizable-strings (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-09-11  Dan Bernstein  <mitz@apple.com>
+
+        REGRESSION (r155561): extract-localizable-strings can miss strings
+        https://bugs.webkit.org/show_bug.cgi?id=121184
+
+        Reviewed by Darin Adler.
+
+        * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
+        parenthesis or bracket.
+
 2013-09-11  Dan Bernstein  <mitz@apple.com>
 

trunk/Tools/Scripts/extract-localizable-strings

@@ -146 +146 @@
         }
 
-        next unless /(\"|\/\*)/;
+        next unless defined $nestingLevel or /(\"|\/\*)/;
     
         # Handle all the tokens in the line.