Changeset 155586 in webkit


Ignore:
Timestamp:
Sep 11, 2013, 7:26:14 PM (12 years ago)
Author:
mark.lam@apple.com
Message:

Fixed indentation in JSC Debugger header files.
​https://bugs.webkit.org/show_bug.cgi?id=121203.

Reviewed by Ryosuke Niwa.

  • debugger/Debugger.h:
  • debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::create):
(JSC::DebuggerActivation::createStructure):

  • debugger/DebuggerCallFrame.h:

(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::callFrame):
(JSC::DebuggerCallFrame::dynamicGlobalObject):
(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::exception):

Location:
trunk/Source/JavaScriptCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r155578 r155586  
     12013-09-11  Mark Lam  <mark.lam@apple.com>
     2
     3        Fixed indentation in JSC Debugger header files.
     4        https://bugs.webkit.org/show_bug.cgi?id=121203.
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        * debugger/Debugger.h:
     9        * debugger/DebuggerActivation.h:
     10        (JSC::DebuggerActivation::create):
     11        (JSC::DebuggerActivation::createStructure):
     12        * debugger/DebuggerCallFrame.h:
     13        (JSC::DebuggerCallFrame::DebuggerCallFrame):
     14        (JSC::DebuggerCallFrame::callFrame):
     15        (JSC::DebuggerCallFrame::dynamicGlobalObject):
     16        (JSC::DebuggerCallFrame::scope):
     17        (JSC::DebuggerCallFrame::exception):
     18
    1192013-09-11  Filip Pizlo  <fpizlo@apple.com>
    220

  • trunk/Source/JavaScriptCore/debugger/Debugger.h

    r148696 r155586  
    2727namespace JSC {
    2828
    29     class DebuggerCallFrame;
    30     class ExecState;
    31     class VM;
    32     class JSGlobalObject;
    33     class JSValue;
    34     class SourceProvider;
     29class DebuggerCallFrame;
     30class ExecState;
     31class VM;
     32class JSGlobalObject;
     33class JSValue;
     34class SourceProvider;
    3535
    36     class JS_EXPORT_PRIVATE Debugger {
    37     public:
    38         virtual ~Debugger();
     36class JS_EXPORT_PRIVATE Debugger {
     37public:
     38    virtual ~Debugger();
    3939
    40         void attach(JSGlobalObject*);
    41         virtual void detach(JSGlobalObject*);
     40    void attach(JSGlobalObject*);
     41    virtual void detach(JSGlobalObject*);
    4242
    43         virtual void sourceParsed(ExecState*, SourceProvider*, int errorLineNumber, const WTF::String& errorMessage) = 0;
     43    virtual void sourceParsed(ExecState*, SourceProvider*, int errorLineNumber, const WTF::String& errorMessage) = 0;
    4444
    45         virtual void exception(const DebuggerCallFrame&, intptr_t, int, int, bool) = 0;
    46         virtual void atStatement(const DebuggerCallFrame&, intptr_t, int, int) = 0;
    47         virtual void callEvent(const DebuggerCallFrame&, intptr_t, int, int) = 0;
    48         virtual void returnEvent(const DebuggerCallFrame&, intptr_t, int, int) = 0;
     45    virtual void exception(const DebuggerCallFrame&, intptr_t, int, int, bool) = 0;
     46    virtual void atStatement(const DebuggerCallFrame&, intptr_t, int, int) = 0;
     47    virtual void callEvent(const DebuggerCallFrame&, intptr_t, int, int) = 0;
     48    virtual void returnEvent(const DebuggerCallFrame&, intptr_t, int, int) = 0;
    4949
    50         virtual void willExecuteProgram(const DebuggerCallFrame&, intptr_t, int, int) = 0;
    51         virtual void didExecuteProgram(const DebuggerCallFrame&, intptr_t, int, int) = 0;
    52         virtual void didReachBreakpoint(const DebuggerCallFrame&, intptr_t, int, int) = 0;
     50    virtual void willExecuteProgram(const DebuggerCallFrame&, intptr_t, int, int) = 0;
     51    virtual void didExecuteProgram(const DebuggerCallFrame&, intptr_t, int, int) = 0;
     52    virtual void didReachBreakpoint(const DebuggerCallFrame&, intptr_t, int, int) = 0;
    5353
     54    void recompileAllJSFunctions(VM*);
    5455
    55         void recompileAllJSFunctions(VM*);
     56private:
     57    HashSet<JSGlobalObject*> m_globalObjects;
     58};
    5659
    57     private:
    58         HashSet<JSGlobalObject*> m_globalObjects;
    59     };
    60 
    61     // This function exists only for backwards compatibility with existing WebScriptDebugger clients.
    62     JS_EXPORT_PRIVATE JSValue evaluateInGlobalCallFrame(const WTF::String&, JSValue& exception, JSGlobalObject*);
     60// This function exists only for backwards compatibility with existing WebScriptDebugger clients.
     61JS_EXPORT_PRIVATE JSValue evaluateInGlobalCallFrame(const WTF::String&, JSValue& exception, JSGlobalObject*);
    6362
    6463} // namespace JSC

  • trunk/Source/JavaScriptCore/debugger/DebuggerActivation.h

    r154459 r155586  
    3131namespace JSC {
    3232
    33     class DebuggerActivation : public JSNonFinalObject {
    34     public:
    35         typedef JSNonFinalObject Base;
     33class DebuggerActivation : public JSNonFinalObject {
     34public:
     35    typedef JSNonFinalObject Base;
    3636
    37         static DebuggerActivation* create(VM& vm, JSObject* object)
    38         {
    39             DebuggerActivation* activation = new (NotNull, allocateCell<DebuggerActivation>(vm.heap)) DebuggerActivation(vm);
    40             activation->finishCreation(vm, object);
    41             return activation;
    42         }
     37    static DebuggerActivation* create(VM& vm, JSObject* object)
     38    {
     39        DebuggerActivation* activation = new (NotNull, allocateCell<DebuggerActivation>(vm.heap)) DebuggerActivation(vm);
     40        activation->finishCreation(vm, object);
     41        return activation;
     42    }
    4343
    44         static void visitChildren(JSCell*, SlotVisitor&);
    45         static String className(const JSObject*);
    46         static bool getOwnPropertySlot(JSObject*, ExecState*, PropertyName, PropertySlot&);
    47         static void put(JSCell*, ExecState*, PropertyName, JSValue, PutPropertySlot&);
    48         static bool deleteProperty(JSCell*, ExecState*, PropertyName);
    49         static void getOwnPropertyNames(JSObject*, ExecState*, PropertyNameArray&, EnumerationMode);
    50         static bool defineOwnProperty(JSObject*, ExecState*, PropertyName, const PropertyDescriptor&, bool shouldThrow);
     44    static void visitChildren(JSCell*, SlotVisitor&);
     45    static String className(const JSObject*);
     46    static bool getOwnPropertySlot(JSObject*, ExecState*, PropertyName, PropertySlot&);
     47    static void put(JSCell*, ExecState*, PropertyName, JSValue, PutPropertySlot&);
     48    static bool deleteProperty(JSCell*, ExecState*, PropertyName);
     49    static void getOwnPropertyNames(JSObject*, ExecState*, PropertyNameArray&, EnumerationMode);
     50    static bool defineOwnProperty(JSObject*, ExecState*, PropertyName, const PropertyDescriptor&, bool shouldThrow);
    5151
    52         DECLARE_EXPORT_INFO;
     52    DECLARE_EXPORT_INFO;
    5353
    54         static Structure* createStructure(VM& vm, JSGlobalObject* globalObject, JSValue prototype)
    55         {
    56             return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
    57         }
     54    static Structure* createStructure(VM& vm, JSGlobalObject* globalObject, JSValue prototype)
     55    {
     56        return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
     57    }
    5858
    59     protected:
    60         static const unsigned StructureFlags = OverridesGetOwnPropertySlot | OverridesVisitChildren | JSObject::StructureFlags;
     59protected:
     60    static const unsigned StructureFlags = OverridesGetOwnPropertySlot | OverridesVisitChildren | JSObject::StructureFlags;
    6161
    62         JS_EXPORT_PRIVATE void finishCreation(VM&, JSObject* activation);
     62    JS_EXPORT_PRIVATE void finishCreation(VM&, JSObject* activation);
    6363
    64     private:
    65         JS_EXPORT_PRIVATE DebuggerActivation(VM&);
    66         WriteBarrier<JSActivation> m_activation;
    67     };
     64private:
     65    JS_EXPORT_PRIVATE DebuggerActivation(VM&);
     66    WriteBarrier<JSActivation> m_activation;
     67};
    6868
    6969} // namespace JSC

  • trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.h

    r128265 r155586  
    3434namespace JSC {
    3535   
    36     class DebuggerCallFrame {
    37     public:
    38         enum Type { ProgramType, FunctionType };
     36class DebuggerCallFrame {
     37public:
     38    enum Type { ProgramType, FunctionType };
    3939
    40         DebuggerCallFrame(CallFrame* callFrame)
    41             : m_callFrame(callFrame)
    42         {
    43         }
     40    DebuggerCallFrame(CallFrame* callFrame)
     41        : m_callFrame(callFrame)
     42    {
     43    }
    4444
    45         DebuggerCallFrame(CallFrame* callFrame, JSValue exception)
    46             : m_callFrame(callFrame)
    47             , m_exception(exception)
    48         {
    49         }
     45    DebuggerCallFrame(CallFrame* callFrame, JSValue exception)
     46        : m_callFrame(callFrame)
     47        , m_exception(exception)
     48    {
     49    }
    5050
    51         CallFrame* callFrame() const { return m_callFrame; }
    52         JSGlobalObject* dynamicGlobalObject() const { return m_callFrame->dynamicGlobalObject(); }
    53         JSScope* scope() const { return m_callFrame->scope(); }
    54         JS_EXPORT_PRIVATE String functionName() const;
    55         JS_EXPORT_PRIVATE String calculatedFunctionName() const;
    56         JS_EXPORT_PRIVATE Type type() const;
    57         JS_EXPORT_PRIVATE JSObject* thisObject() const;
    58         JS_EXPORT_PRIVATE JSValue evaluate(const String&, JSValue& exception) const;
    59         JSValue exception() const { return m_exception; }
     51    CallFrame* callFrame() const { return m_callFrame; }
     52    JSGlobalObject* dynamicGlobalObject() const { return m_callFrame->dynamicGlobalObject(); }
     53    JSScope* scope() const { return m_callFrame->scope(); }
     54    JS_EXPORT_PRIVATE String functionName() const;
     55    JS_EXPORT_PRIVATE String calculatedFunctionName() const;
     56    JS_EXPORT_PRIVATE Type type() const;
     57    JS_EXPORT_PRIVATE JSObject* thisObject() const;
     58    JS_EXPORT_PRIVATE JSValue evaluate(const String&, JSValue& exception) const;
     59    JSValue exception() const { return m_exception; }
    6060
    61     private:
    62         CallFrame* m_callFrame;
    63         JSValue m_exception;
    64     };
     61private:
     62    CallFrame* m_callFrame;
     63    JSValue m_exception;
     64};
    6565
    6666} // namespace JSC
Note: See TracChangeset for help on using the changeset viewer.