Changeset 155882 in webkit


Ignore:
Timestamp:
Sep 16, 2013 10:40:07 AM (11 years ago)
Author:
ap@apple.com
Message:

svg/animations/smil-leak-*.svg tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=114280

Reviewed by Geoffrey Garen.

Try garbage collection multiple times, who knows which queues the deleted nodes
could still be in. Also, removed last week's experimental change to make 10x more
nodes to see how that affects the number of leaks (it didn't).

  • svg/animations/smil-leak-dynamically-added-element-instances.svg:
  • svg/animations/smil-leak-element-instances-noBaseValRef.svg:
  • svg/animations/smil-leak-element-instances.svg:
  • svg/animations/smil-leak-elements.svg:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r155877 r155882  
     12013-09-16  Alexey Proskuryakov  <ap@apple.com>
     2
     3        svg/animations/smil-leak-*.svg tests are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=114280
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Try garbage collection multiple times, who knows which queues the deleted nodes
     9        could still be in. Also, removed last week's experimental change to make 10x more
     10        nodes to see how that affects the number of leaks (it didn't).
     11
     12        * svg/animations/smil-leak-dynamically-added-element-instances.svg:
     13        * svg/animations/smil-leak-element-instances-noBaseValRef.svg:
     14        * svg/animations/smil-leak-element-instances.svg:
     15        * svg/animations/smil-leak-elements.svg:
     16
    1172013-09-16  Alexey Proskuryakov  <ap@apple.com>
    218

  • trunk/LayoutTests/svg/animations/smil-leak-dynamically-added-element-instances.svg

    r155728 r155882  
    3838    originalLiveElements = window.internals.numberOfLiveNodes();
    3939
    40     for (var i = 0; i < 500; i++)
     40    for (var i = 0; i < 50; i++)
    4141        g.appendChild(createAnimatedRectInstance());
    4242
    … …  
    4545
    4646function addMoreInstances() {
    47     for (var i = 0; i < 500; i++)
     47    for (var i = 0; i < 50; i++)
    4848        g.appendChild(createAnimatedRectInstance());
    4949   
    … …  
    5858}
    5959
     60var attemptsToFinish = 5;
     61
    6062function finishTest() {
    6163    GCController.collect();
    … …  
    6466    if (liveDelta == 0)
    6567        log("PASS");
    66     else
     68    else if (--attemptsToFinish) {
     69        setTimeout(finishTest, 0);
     70        return;
     71    } else
    6772        log("FAIL: " + liveDelta + " extra live node(s)");
    6873

  • trunk/LayoutTests/svg/animations/smil-leak-element-instances-noBaseValRef.svg

    r155728 r155882  
    3838    originalLiveElements = window.internals.numberOfLiveNodes();
    3939
    40     for (var i = 0; i < 1000; i++)
     40    for (var i = 0; i < 100; i++)
    4141        g.appendChild(createAnimatedRectInstance());
    4242
    … …  
    5151}
    5252
     53var attemptsToFinish = 5;
     54
    5355function finishTest() {
    5456    GCController.collect();
    … …  
    5759    if (liveDelta == 0)
    5860        log("PASS");
    59     else
     61    else if (--attemptsToFinish) {
     62        setTimeout(finishTest, 0);
     63        return;
     64    } else
    6065        log("FAIL: " + liveDelta + " extra live node(s)");
    6166

  • trunk/LayoutTests/svg/animations/smil-leak-element-instances.svg

    r155728 r155882  
    4141    xBaseVal = document.getElementById("rect").x.baseVal;
    4242
    43     for (var i = 0; i < 1000; i++)
     43    for (var i = 0; i < 100; i++)
    4444        g.appendChild(createAnimatedRectInstance());
    4545
    … …  
    5454}
    5555
     56var attemptsToFinish = 5;
     57
    5658function finishTest() {
    5759    GCController.collect();
    … …  
    6062    if (liveDelta == 0)
    6163        log("PASS");
    62     else
     64    else if (--attemptsToFinish) {
     65        setTimeout(finishTest, 0);
     66        return;
     67    } else
    6368        log("FAIL: " + liveDelta + " extra live node(s)");
    6469

  • trunk/LayoutTests/svg/animations/smil-leak-elements.svg

    r155728 r155882  
    3636    originalLiveElements = window.internals.numberOfLiveNodes();
    3737
    38     for (var i = 0; i < 1000; i++)
     38    for (var i = 0; i < 100; i++)
    3939        g.appendChild(createAnimatedRect());
    4040
    … …  
    4949}
    5050
     51var attemptsToFinish = 5;
     52
    5153function finishTest() {
    5254    GCController.collect();
    … …  
    5557    if (liveDelta == 0)
    5658        log("PASS");
    57     else
     59    else if (--attemptsToFinish) {
     60        setTimeout(finishTest, 0);
     61        return;
     62    } else
    5863        log("FAIL: " + liveDelta + " extra live node(s)");
    5964
Note: See TracChangeset for help on using the changeset viewer.