Changeset 156431 in webkit

Timestamp:

Sep 25, 2013 4:18:39 PM (11 years ago)

Author:

ap@apple.com

Message:

Flaky Test: fast/history/history-subframe-with-name.html
​https://bugs.webkit.org/show_bug.cgi?id=51039

Reviewed by Brady Eidson.

• fast/history/history-subframe-with-name.html: In state 3, there was a race between

history.forward() and navigating to a new URL. Not sure how this resulted in an
extra load, but let's get rid of that. Also, extended failure logging.

• fast/history/resources/history-subframe-with-name-2.html: No longer do the

navigation unconditionally. We need it in state 1, but not in state 3.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/history/history-subframe-with-name.html (modified) (2 diffs)
• fast/history/resources/history-subframe-with-name-2.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-09-25  Alexey Proskuryakov  <ap@apple.com>
+
+        Flaky Test: fast/history/history-subframe-with-name.html
+        https://bugs.webkit.org/show_bug.cgi?id=51039
+
+        Reviewed by Brady Eidson.
+
+        * fast/history/history-subframe-with-name.html: In state 3, there was a race between
+        history.forward() and navigating to a new URL. Not sure how this resulted in an
+        extra load, but let's get rid of that. Also, extended failure logging.
+
+        * fast/history/resources/history-subframe-with-name-2.html: No longer do the
+        navigation unconditionally. We need it in state 1, but not in state 3.
+
 2013-09-25  Roger Fong  <roger_fong@apple.com>
 

trunk/LayoutTests/fast/history/history-subframe-with-name.html

@@ -44 +44 @@
       case 1:
           shouldBe('2', 'currentPageId');
+          // Make sure we generate a history entry.
+          setTimeout(function() { testWindow.frames[0].location.href = 'resources/history-subframe-with-name-3.html' }, 0);
           break;
       case 2:
@@ -57 +59 @@
           break;
       default:
-          testFailed('Should not be in state ' + currentState);
+          testFailed('Should not be in state ' + currentState + ". currentPageId is " + currentPageId);
           break;
     }

trunk/LayoutTests/fast/history/resources/history-subframe-with-name-2.html

@@ -9 +9 @@
       }
       parent.opener.onFrameLoaded(2);
-      // Make sure we generate a history entry
-      setTimeout(function() {location.href = 'history-subframe-with-name-3.html';}, 0);
   }
 </script>