Changeset 157429 in webkit

Timestamp:

Oct 14, 2013, 4:30:37 PM (12 years ago)

Author:

mark.lam@apple.com

Message:

Add FTL support for LogicalNot(string)
​https://bugs.webkit.org/show_bug.cgi?id=122765

Patch by Nadav Rotem <​nrotem@apple.com> on 2013-10-14
Reviewed by Filip Pizlo.

This patch is tested by:
regress/script-tests/emscripten-cube2hash.js.ftl-eager

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• ftl/FTLCapabilities.cpp (modified) (1 diff)
• ftl/FTLLowerDFGToLLVM.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-10-14  Nadav Rotem  <nrotem@apple.com>
+
+        Add FTL support for LogicalNot(string)
+        https://bugs.webkit.org/show_bug.cgi?id=122765
+
+        Reviewed by Filip Pizlo.
+
+        This patch is tested by:
+        regress/script-tests/emscripten-cube2hash.js.ftl-eager
+
+        * ftl/FTLCapabilities.cpp:
+        (JSC::FTL::canCompile):
+        * ftl/FTLLowerDFGToLLVM.cpp:
+        (JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
+
 2013-10-14  Julien Brianceau  <jbriance@cisco.com>
 

trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp

@@ -190 +190 @@
         case Int32Use:
         case NumberUse:
+        case StringUse:
         case ObjectOrOtherUse:
             break;

trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp

@@ -2110 +2110 @@
                     edge, CellCaseSpeculatesObject, SpeculateNullOrUndefined,
                     ManualOperandSpeculation));
+        case StringUse: {
+            LValue stringValue = lowString(m_node->child1());
+            LValue length = m_out.load32(stringValue, m_heaps.JSString_length);
+            return m_out.notEqual(length, m_out.int32Zero);
+        }
         default:
             RELEASE_ASSERT_NOT_REACHED();