Changeset 157687 in webkit

Timestamp:

Oct 19, 2013 4:38:14 PM (11 years ago)

Author:

rniwa@webkit.org

Message:

run-webkit-tests should submit time and modifiers to the new flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=123070

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

• Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
in the test expectations when this argument is set to true.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/controllers/manager.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/models/test_run_results.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
+
+        run-webkit-tests should submit time and modifiers to the new flakiness dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=123070
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Scripts/webkitpy/layout_tests/controllers/manager.py:
+        (Manager.run):
+        * Scripts/webkitpy/layout_tests/models/test_run_results.py:
+        (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
+        in the test expectations when this argument is set to true.
+
 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -229 +229 @@
         results_including_passes = None
         if self._options.results_server_host:
-            results_including_passes = test_run_results.summarize_results(self._port, self._expectations, initial_results, retry_results, enabled_pixel_tests_in_retry, include_passes=True)
+            results_including_passes = test_run_results.summarize_results(self._port, self._expectations, initial_results, retry_results, enabled_pixel_tests_in_retry, include_passes=True, include_time_and_modifiers=True)
         self._printer.print_results(end_time - start_time, initial_results, summarized_results)
 

trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

@@ -119 +119 @@
 
 
-def summarize_results(port_obj, expectations, initial_results, retry_results, enabled_pixel_tests_in_retry, include_passes=False):
+def summarize_results(port_obj, expectations, initial_results, retry_results, enabled_pixel_tests_in_retry, include_passes=False, include_time_and_modifiers=False):
     """Returns a dictionary containing a summary of the test runs, with the following fields:
         'version': a version indicator
@@ -202 +202 @@
         test_dict['expected'] = expected
         test_dict['actual'] = " ".join(actual)
+        if include_time_and_modifiers:
+            test_dict['time'] = round(1000 * result.test_run_time)
+            # FIXME: Fix get_modifiers to return modifiers in new format.
+            test_dict['modifiers'] = ' '.join(expectations.get_modifiers(test_name)).replace('BUGWK', 'webkit.org/b/')
 
         test_dict.update(_interpret_test_failures(result.failures))