Changeset 157776 in webkit

Timestamp:

Oct 21, 2013 10:16:38 PM (11 years ago)

Author:

mitz@apple.com

Message:

[Cocoa] Add load delegate method for didChangeBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=123136

Reviewed by Anders Carlsson.

• UIProcess/API/mac/WKBrowsingContextController.mm:

(didChangeBackForwardList): Added. Calls new delegate method.
(setUpPageLoaderClient): Hook up new client function.

• UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Declare new delegate method.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/mac/WKBrowsingContextController.mm (modified) (3 diffs)
• UIProcess/API/mac/WKBrowsingContextLoadDelegate.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-10-21  Dan Bernstein  <mitz@apple.com>
+
+        [Cocoa] Add load delegate method for didChangeBackForwardList
+        https://bugs.webkit.org/show_bug.cgi?id=123136
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/API/mac/WKBrowsingContextController.mm:
+        (didChangeBackForwardList): Added. Calls new delegate method.
+        (setUpPageLoaderClient):  Hook up new client function.
+        * UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Declare new delegate method.
+
 2013-10-21  Mark Rowe  <mrowe@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm

@@ -31 +31 @@
 #import "ObjCObjectGraph.h"
 #import "WKBackForwardListInternal.h"
+#import "WKBackForwardListItemInternal.h"
 #import "WKErrorCF.h"
 #import "WKFrame.h"
+#import "WKNSArray.h"
 #import "WKPagePrivate.h"
 #import "WKRetainPtr.h"
@@ -489 +491 @@
 }
 
+static void didChangeBackForwardList(WKPageRef page, WKBackForwardListItemRef addedItem, WKArrayRef removedItems, const void *clientInfo)
+{
+    WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
+    if (![browsingContext.loadDelegate respondsToSelector:@selector(browsingContextControllerDidChangedBackForwardList:addedItem:removedItems:)])
+        return;
+
+    WKBackForwardListItem *added = addedItem ? [[WKBackForwardListItem alloc] _initWithItem:*toImpl(addedItem)] : nil;
+    NSArray *removed = removedItems ? [[WKNSArray alloc] web_initWithImmutableArray:*toImpl(removedItems)] : nil;
+    [browsingContext.loadDelegate browsingContextControllerDidChangedBackForwardList:browsingContext addedItem:added removedItems:removed];
+    [added release];
+    [removed release];
+}
+
 static void setUpPageLoaderClient(WKBrowsingContextController *browsingContext, WKPageRef pageRef)
 {
@@ -507 +522 @@
     loaderClient.didFinishProgress = didFinishProgress;
 
+    loaderClient.didChangeBackForwardList = didChangeBackForwardList;
+
     WKPageSetPageLoaderClient(pageRef, &loaderClient);
 }

trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h

@@ -53 +53 @@
 - (void)browsingContextControllerDidFinishProgress:(WKBrowsingContextController *)sender;
 
+- (void)browsingContextControllerDidChangedBackForwardList:(WKBrowsingContextController *)sender addedItem:(WKBackForwardListItem *)addedItem removedItems:(NSArray *)removedItems;
+
 @end