Changeset 157937 in webkit


Ignore:
Timestamp:
Oct 24, 2013, 10:05:57 AM (12 years ago)
Author:
mark.lam@apple.com
Message:

Better way to fix part of broken C Loop LLINT build.
​https://bugs.webkit.org/show_bug.cgi?id=123271.

Reviewed by Geoffrey Garen.

Undoing offline asm hackery.

  • llint/LowLevelInterpreter.cpp:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/cloop.rb:
  • offlineasm/instructions.rb:
Location:
trunk/Source/JavaScriptCore
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r157932 r157937  
     12013-10-24  Mark Lam  <mark.lam@apple.com>
     2
     3        Better way to fix part of broken C Loop LLINT build.
     4        https://bugs.webkit.org/show_bug.cgi?id=123271.
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Undoing offline asm hackery.
     9
     10        * llint/LowLevelInterpreter.cpp:
     11        * llint/LowLevelInterpreter32_64.asm:
     12        * llint/LowLevelInterpreter64.asm:
     13        * offlineasm/cloop.rb:
     14        * offlineasm/instructions.rb:
     15
    1162013-10-24  Mark Lam  <mark.lam@apple.com>
    217

  • trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp

    r157572 r157937  
    9999#endif
    100100
    101 #define OFFLINE_ASM_LOCAL_LABEL(label)   label:
     101#define OFFLINE_ASM_LOCAL_LABEL(label) \
     102    label: \
     103        if (false) \
     104            goto label;
    102105
    103106

  • trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm

    r157932 r157937  
    13901390_llint_op_put_by_val_direct:
    13911391    putByVal(macro(addr, slowPath)
    1392         if C_LOOP
    1393             cloopUnusedLabel slowPath
    1394         end
    13951392    end, _llint_slow_path_put_by_val_direct)
    13961393

  • trunk/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm

    r157932 r157937  
    12491249_llint_op_put_by_val_direct:
    12501250    putByVal(macro(slot, slowPath)
    1251         if C_LOOP
    1252             cloopUnusedLabel slowPath
    1253         end
    12541251    end, _llint_slow_path_put_by_val_direct)
    12551252

  • trunk/Source/JavaScriptCore/offlineasm/cloop.rb

    r157932 r157937  
    11111111            cloopEmitCallSlowPath(operands)
    11121112
    1113         when "cloopUnusedLabel"
    1114             $asm.putc "if (false) goto #{operands[0].cLabel};"
    1115 
    11161113        # For debugging only. This is used to insert instrumentation into the
    11171114        # generated LLIntAssembly.h during llint development only. Do not use

  • trunk/Source/JavaScriptCore/offlineasm/instructions.rb

    r157932 r157937  
    296296     "cloopCallNative",      # operands: callee
    297297     "cloopCallSlowPath",    # operands: callTarget, currentFrame, currentPC
    298      "cloopUnusedLabel",     # operands: label
    299298
    300299     # For debugging only:
Note: See TracChangeset for help on using the changeset viewer.